Skip to content
This repository has been archived by the owner on Nov 19, 2021. It is now read-only.

Fix typo in the 'sufix' argument for make_mead #138

Merged
merged 1 commit into from
Dec 10, 2018

Conversation

tmckayus
Copy link
Contributor

@tmckayus tmckayus commented Dec 5, 2018

Checklist:

  • Have you added a note in the CHANGELOG.md for your change if user-facing?
  • Have you added unit tests for your change?

@tmckayus
Copy link
Contributor Author

tmckayus commented Dec 5, 2018

My tiny contribution to PNC :) Noticed a typo in the help

@thescouser89
Copy link
Contributor

@michalszynkiewicz Does PiG use the suffix option?

@thescouser89
Copy link
Contributor

Thanks for the change @tmckayus ! Just want to make sure that the other tools consuming pnc-cli are not affected :)

@michalszynkiewicz
Copy link
Contributor

nah, we don't use make-mead at all

@thescouser89
Copy link
Contributor

@tmckayus A tiny favour :D Could you also edit the CHANGELOG.md to include your chage in the changed section for unreleased? We use the changelog to let our users know about changes in the new release.

@thescouser89
Copy link
Contributor

@michalszynkiewicz Thanks for checking! :)

@tmckayus
Copy link
Contributor Author

tmckayus commented Dec 7, 2018

@thescouser89 I thought I did, is there something missing from the current CHANGELOG.md?

@tmckayus A tiny favour :D Could you also edit the CHANGELOG.md to include your chage in the changed section for unreleased? We use the changelog to let our users know about changes in the new release.

@thescouser89
Copy link
Contributor

@tmckayus SORRY my bad! My eyes sometimes lie to me! :D

@thescouser89 thescouser89 merged commit 3dc149b into project-ncl:master Dec 10, 2018
@thescouser89
Copy link
Contributor

Merged! Thank you so much for your contribution!!! :)

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants