[NCL-4538] Add new BUILDER_POD_MEMORY parameter #2376
Conversation
|
Waiting for 1.5 branch for this PR |
| @@ -48,7 +51,8 @@ StartedEnvironment startEnvironment( | |||
| SystemImageType systemImageType, | |||
| RepositorySession repositorySession, | |||
| DebugData debugData, | |||
| String accessToken) throws EnvironmentDriverException; | |||
| String accessToken, | |||
| Map<String, String> parameters) throws EnvironmentDriverException; | |||
There was a problem hiding this comment.
It would be better to use specific parameter instead of the map.
There was a problem hiding this comment.
I understand (generic) parameters to be a map that is passed to various services and they rocognize their parameters and use them: CUSTOM_PME_PARAMETERS is consumed by PME, EXECUTION_ROOT_NAME is consumed by Repour and BUILDER_POD_MEMORY would be consumed by environment drivers.
You think it should be some other service/part that would consume the BUILDER_POD_MEMORY parameter?
There was a problem hiding this comment.
The API that defines what is required rather than taking the map of Strings is more readable.
The other thing is OpenshiftStartedEnvironment it is an implementation details that does not need to know about the Keys in the generic parametrs map.
I see the use case you described more on the REST api level. On the other side I see that repository driver has been done in the same way.
|
@janinko Don't wait for branch 1.5. There are also commits in the 1.4, which will be released as 1.5. Once the PR is ready, merge it. We will sort out the branches when releasing. |
|
Sorry, missclick. Why are the buttons to close and comment so close to each other... |
Checklist: