Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve oak functions benchmarks #4706

Open
tiziano88 opened this issue Jan 24, 2024 · 4 comments
Open

Improve oak functions benchmarks #4706

tiziano88 opened this issue Jan 24, 2024 · 4 comments
Assignees

Comments

@tiziano88
Copy link
Collaborator

No description provided.

@tiziano88 tiziano88 self-assigned this Jan 24, 2024
@tiziano88
Copy link
Collaborator Author

cc @waywardgeek

@tiziano88
Copy link
Collaborator Author

cc @andrisaar

@tiziano88
Copy link
Collaborator Author

@pmcgrath17

@tiziano88
Copy link
Collaborator Author

I am modifying the existing bench.

Somewhat interesting results.

For an echo Wasm module:

test wasm::tests::bench_invoke_echo   ... bench:      88,085 ns/iter (+/- 6,912)

For a k/v lookup Wasm module that does a single lookup:

test wasm::tests::bench_invoke_lookup ... bench:     104,695 ns/iter (+/- 9,098)

If I increase the number of lookups to 100:

test wasm::tests::bench_invoke_lookup ... bench:   1,685,143 ns/iter (+/- 556,036)

And to 1,000:

test wasm::tests::bench_invoke_lookup ... bench:  15,497,293 ns/iter (+/- 584,814)

And to 10,000:

test wasm::tests::bench_invoke_lookup ... bench: 155,914,223 ns/iter (+/- 14,439,435)

So, it seems to scale roughly linearly, as we would expect naively.

But now I would like to see if @waywardgeek 's suggestion of introducing batching, but at the Wasm lookup logic level, makes things any better.

tiziano88 added a commit to tiziano88/oak that referenced this issue Jan 24, 2024
tiziano88 added a commit to tiziano88/oak that referenced this issue Jan 24, 2024
tiziano88 added a commit to tiziano88/oak that referenced this issue Jan 24, 2024
tiziano88 added a commit to tiziano88/oak that referenced this issue Jan 24, 2024
tiziano88 added a commit to tiziano88/oak that referenced this issue Jan 25, 2024
tiziano88 added a commit to tiziano88/oak that referenced this issue Jan 25, 2024
tiziano88 added a commit that referenced this issue Jan 25, 2024
k-naliuka pushed a commit to k-naliuka/oak that referenced this issue Feb 5, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant