Add KMS support to crypto pseudo-Node #1846
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
daviddrysdale
force-pushed
the
kms
branch
4 times, most recently
from
d7d5371
to
d72e6c4
Compare
6 tasks
daviddrysdale
force-pushed
the
kms
branch
3 times, most recently
from
c310961
to
2bab9d4
Compare
oak_runtime/Cargo.toml
Outdated
| @@ -53,7 +53,10 @@ serde_json = "*" | |||
| sha2 = "^0.9.1" | |||
| tink-core = { version = "^0.1", features = ["json"] } | |||
| tink-aead = "^0.1" | |||
| tink-awskms = "^0.1" | |||
There was a problem hiding this comment.
Is it feasible to make KMS support feature-gated? These KMS support dependencies worry me, and I would prefer to not always include it in the TCB unless someone really wants to use KMS integration.
There was a problem hiding this comment.
Good point, will do.
daviddrysdale
force-pushed
the
kms
branch
2 times, most recently
from
7a34f19
to
7cfbfa3
Compare
Not ideal because different features can't be specified independently, but that's a bigger/different change.
conradgrobler
approved these changes
Feb 5, 2021
| "retrieve KMS client for {} using credentials in {:?}", | ||
| key_uri, self.kms_credentials | ||
| ); | ||
| #[cfg(feature = "awskms")] |
There was a problem hiding this comment.
Nice. I like how locally contained the feature scoping ended up being.
|
Reproducibility Index: Reproducibility Index diff: diff --git a/reproducibility_index b/reproducibility_index
index d2bd887..5f21d35 100644
--- a/reproducibility_index
+++ b/reproducibility_index
@@ -10,4 +10,4 @@ b43a49ae8e06e165e282ed877050f1ab61ac84ffed8d04011c5dfbd9ea79b5e6 ./examples/inj
e7baa8bbf76625baa88769d8a31e250886ad5ab527a7af0f0474400b278e5530 ./examples/private_set_intersection/bin/private_set_intersection_handler.wasm
8c97d83fe6aa157dbbb01b0931e206bc4d9da058adfc2e0df46a7d1979c495c2 ./examples/translator/bin/translator.wasm
281511f222523d02d7a369d6b00c8f4e80d3ad6754af29a04e8b4864fbc1a2bc ./examples/trusted_database/bin/trusted_database.wasm
-f7f13572ca737e414e848807894b40f6bf8e1cb5d4d742986b40b85c4feac1b8 ./oak_loader/bin/oak_loader
+7d2ab6e28054bc5a697a46e6b5acf9cf3d2a618db92212f19038fc0e402c275f ./oak_loader/bin/oak_loader
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Checklist
Cloudbuild
cover any TODOs and/or unfinished work.
construction.