Add linear-handles feature to SDK. #1884
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wildarch
force-pushed
the
oak_sdk_linear_handles_feature
branch
from
c53116a
to
9f50ded
Compare
rbehjati
approved these changes
Feb 19, 2021
| @@ -5,14 +5,19 @@ authors = ["Tiziano Santoro <tzn@google.com>"] | |||
| edition = "2018" | |||
| license = "Apache-2.0" | |||
|
|
|||
| [features] | |||
| default = ["no-linear-handles"] | |||
| no-linear-handles = ["oak_io/no-linear-handles"] | |||
There was a problem hiding this comment.
Are both no-linear-handles and linear-handles still needed now that the features are added to SDK?
There was a problem hiding this comment.
I'm afraid we do. Some of the examples are not compatible with the 'linear-handles' feature (I think it's just abitest and injection), and will cause a build failure for the examples workspace without having a no-linear-handles feature to cancel out the linear-handles one.
Once those examples are fixed, we can get rid of this feature 😄
There was a problem hiding this comment.
I see. Thanks for the clarification :)
|
Reproducibility Index: Reproducibility Index diff: diff --git a/reproducibility_index b/reproducibility_index
index 87b4b34..a8f1316 100644
--- a/reproducibility_index
+++ b/reproducibility_index
@@ -1,15 +1,15 @@
-3b9bf47c09f52c2035409b29aa7ccf3dbf0b198d542c9142ee0803e2780255db ./examples/abitest/bin/abitest_0_frontend.wasm
-20f395e082b2dd75b698bd2c1b7542a11fae757c229de4129f268e6b8b2abe53 ./examples/abitest/bin/abitest_1_backend.wasm
-a5b271718d45f17bad093efc9dff2749d7f26ceadfd81120be6c20b169bc6dfb ./examples/abitest/bin/abitest_linear_handles.wasm
-8d890bcade31c6c8ab1926f5ece344de1664321b96401d7f3885ebafad570a68 ./examples/aggregator/bin/aggregator.wasm
-77e6001774063f7e351d5ec13259cf07301b8a8ba79e9a11496ba8c651892ce3 ./examples/chat/bin/chat.wasm
-9ad7c6cb5e17451fcdff397564a5ae963dfcf4863c204b6edba282e0dc10bd7a ./examples/hello_world/bin/hello_world.wasm
-2235d306f8c3baf5d5e5736f43972d6490f52570ad87b5ab1422c5ce079b9537 ./examples/hello_world/bin/translator.wasm
-321d2ef8f44c6a5d8ea41462098cc69ce6f1ccf8a24072900cb8f02381206d50 ./examples/http_server/bin/http_server.wasm
-84076e05bf95ecd97dc29079b5c7f0690b3ba52838be0504f0642484c86c8784 ./examples/injection/bin/injection.wasm
-87a30147d0f0c4e194ffb9d3b74ce083084e3deb505cd7a99b183b202843934a ./examples/private_set_intersection/bin/private_set_intersection.wasm
-dbde9e581d72c9f4307d5dbd4504a3ede20b7bd7359fe389699fb9712ac8baf3 ./examples/private_set_intersection/bin/private_set_intersection_handler.wasm
-409182b9bd6aa0701f0bc06ecadd9fa2dd8d1c0cd2de45a0e250c888e4cd0bbf ./examples/proxy_attestation/bin/proxy_attestation_example.wasm
-2235d306f8c3baf5d5e5736f43972d6490f52570ad87b5ab1422c5ce079b9537 ./examples/translator/bin/translator.wasm
-8999999ce4051b31d0bcd7a869b656883c8828663f44378f30f7dfe81da8f681 ./examples/trusted_database/bin/trusted_database.wasm
-120af7a03ceab95ee613c2c936a7451ea635a5691e68965aa8e6a4c5685353b4 ./oak_loader/bin/oak_loader
+ee8c08fbe8132e1d1f11ab0c811407c18a315625bfb24953d39beb858db173c4 ./examples/abitest/bin/abitest_0_frontend.wasm
+8400e545655f67486ea6fee06aaaae9cf2aadecefc3b4288dcb4bfb187db5d83 ./examples/abitest/bin/abitest_1_backend.wasm
+de915d71e5f77362f64eeb1924a349a3b8bc416e4d8bb8614913e2d96b432a10 ./examples/abitest/bin/abitest_linear_handles.wasm
+7a3d2479d81fe14c10f9874e5bfba1185b3c0d4f86b453fa01eed682aa305e50 ./examples/aggregator/bin/aggregator.wasm
+ad69eeeb74eed3a6185210cf4898749eed2d44617557d1327261774faa1e243c ./examples/chat/bin/chat.wasm
+5edcb3c4a605d6a237a88e06d142b3796c388212895b3257e4eac1ac7c1c1d96 ./examples/hello_world/bin/hello_world.wasm
+24694ff8201d5a3488366c0f86bb81cad8dfedca72fa0559a6820c656027986f ./examples/hello_world/bin/translator.wasm
+7c0855819b0c188f1a83478868915fe847fe8b847108ccc30a93c5110cb95fde ./examples/http_server/bin/http_server.wasm
+9d7987628d9a520c64794dba9b76ee597d9b3f93b46186c01fc00bd7e24606fe ./examples/injection/bin/injection.wasm
+fe327b49cc0ddcf6237952fa962e3a20d3293d7a5d063857cb3f01a5cce77d35 ./examples/private_set_intersection/bin/private_set_intersection.wasm
+d70324138043c16ea812fbd6ce3a75a82aea7a97d13de4570c790d4ab1dda903 ./examples/private_set_intersection/bin/private_set_intersection_handler.wasm
+97f5455a87aa2de4a401a75e8c12a8b49dc3e732d3b85bc8688f5386ad3e54a5 ./examples/proxy_attestation/bin/proxy_attestation_example.wasm
+24694ff8201d5a3488366c0f86bb81cad8dfedca72fa0559a6820c656027986f ./examples/translator/bin/translator.wasm
+4d2bbcd612282243e85331c187d8f9004779e5724e8c02bdf8f93339ad9bd485 ./examples/trusted_database/bin/trusted_database.wasm
+dcfd1aec80c6482e1e1c1dcb0846d0abf11f5531bf1c2b434e84f128e010ccdd ./oak_loader/bin/oak_loader
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Checklist
Cloudbuild
cover any TODOs and/or unfinished work.
construction.