Migrate examples use linear handles (except abitest) #1909
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wildarch
force-pushed
the
migrate-examples-linear-handles
branch
3 times, most recently
from
f631468
to
cc928a3
Compare
wildarch
force-pushed
the
migrate-examples-linear-handles
branch
from
c73a556
to
12ee27f
Compare
rbehjati
approved these changes
Apr 1, 2021
| @@ -12,17 +12,12 @@ crate-type = ["cdylib"] | |||
| anyhow = "*" | |||
| log = "*" | |||
| oak_abi = "=0.1.0" | |||
| oak_io = "=0.1.0" | |||
| oak_services = "=0.1.0" | |||
| prost = "*" | |||
|
|
|||
| [dependencies.oak] | |||
There was a problem hiding this comment.
Could this now be changed to oak = { version = "=0.1.0", features = ["linear-handles"] } to be more consistent throughout.
There was a problem hiding this comment.
Yes, good point! Done.
Yes, that will be the next step once we merge this and #1916 |
wildarch
force-pushed
the
migrate-examples-linear-handles
branch
from
b32b4db
to
df10125
Compare
This leaves just abitest to migrate.
wildarch
force-pushed
the
migrate-examples-linear-handles
branch
from
df10125
to
af69a75
Compare
|
🎉 |
|
Reproducibility Index: Reproducibility Index diff: diff --git a/reproducibility_index b/reproducibility_index
index 14ab1dd..f57eca2 100644
--- a/reproducibility_index
+++ b/reproducibility_index
@@ -1,16 +1,16 @@
2bb36583dc89af9ed53bd472d14f887d071ef877fe86c2c21016fc91d8407722 ./examples/abitest/bin/abitest_0_frontend.wasm
1dee38c4eb66e751639540530bace7e8b8befb38afda120f1e283da55d302021 ./examples/abitest/bin/abitest_1_backend.wasm
f88e4a49982d1abf8a5239639f890d8eecb0fc2734913b1b0a7a8ee1e1f68ee1 ./examples/abitest/bin/abitest_linear_handles.wasm
-5df07e7163209d363d9c4733910a71947582403627e2916a0daea661052360c6 ./examples/aggregator/bin/aggregator.wasm
-080c437c6668f050d3d50c76d6f1a21c186bc3fa2bf08a39e45c4cce7b9440fc ./examples/chat/bin/chat.wasm
+8757bbf4c470b1c33c830a37fb9ce95feb56fe9b2b1a7003d3150ef21a9ea31a ./examples/aggregator/bin/aggregator.wasm
+0c532354ab48c7dbccc7ae9350f07ad9e2e4d905248d7098cbaeceba92ea4925 ./examples/chat/bin/chat.wasm
138ddd9e68f9c526f0394530dd15df45e692b9d24f1515073667e5d41c4533da ./examples/hello_world/bin/hello_world.wasm
-34abe16461c447a1608766aaa5f18098c720244d5c45786cd872f3343eb658b0 ./examples/hello_world/bin/translator.wasm
+fd6619cfde74e44f13ae0abd24d5ae6e26abb856a7e5a596d04bf568d744ea36 ./examples/hello_world/bin/translator.wasm
350e7732cf89764361e989b63df67ccc943fbfcc6a9cbfdef777ba11ac5382bf ./examples/http_server/bin/http_server.wasm
56f34bccf3eda180022d151e98bb4fcc5a651cbc3b9c0910241b91c039206c71 ./examples/injection/bin/injection.wasm
-28b014ccf9f354eb8b3a40845da1a61e9772baea79165abf042e211681278db5 ./examples/private_set_intersection/bin/private_set_intersection.wasm
-214e21108946301304b9de6e10a467d5aa045b171c7903ff5c3cb8f030c508c9 ./examples/private_set_intersection/bin/private_set_intersection_handler.wasm
-e7224705a10468d1b8d9783205161de60d03b49cea5fcb3558e36a4bbcb5a0f8 ./examples/proxy_attestation/bin/proxy_attestation_example.wasm
-34abe16461c447a1608766aaa5f18098c720244d5c45786cd872f3343eb658b0 ./examples/translator/bin/translator.wasm
-16261a9c77cef14ccee46e4e665b23f3e2e747eb8489e57ae2072280516a875d ./examples/trusted_database/bin/trusted_database.wasm
+e14e2ed88e58e2da091f4799c599ef6f6b92133575101967d20071711dc892dc ./examples/private_set_intersection/bin/private_set_intersection.wasm
+1acbc6736491a777373727a9a48047b0904461f34bd7711a36cd5a3bade00e86 ./examples/private_set_intersection/bin/private_set_intersection_handler.wasm
+f8e62bfc9f5b072f45622bb8983aa65819fc90c5e9e674fc1084fb02e892bcac ./examples/proxy_attestation/bin/proxy_attestation_example.wasm
+fd6619cfde74e44f13ae0abd24d5ae6e26abb856a7e5a596d04bf568d744ea36 ./examples/translator/bin/translator.wasm
+4131b3bceb582f1f79e0624794af087ba683401a003e9ec000f4b9c8644626f2 ./examples/trusted_database/bin/trusted_database.wasm
ee61eb8f9c800623a56d6cec8b07dd0cd3b3f24d9899c6584393dbd3eacabede ./oak_loader/bin/oak_loader
c60d0cbad2e1269aae253e805554ac2bbd70c7ccd5907277e6e90cee98355f09 ./oak_functions/loader/bin/oak_functions_loader
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Checklist
Cloudbuild
cover any TODOs and/or unfinished work.
construction.
This leaves just
abitestleft to migrate.Based on #1915.
Tracking issue: #1854.