Declare crate for generated proto Rust code #4701
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
conradgrobler
approved these changes
Jan 23, 2024
| @@ -20,9 +20,6 @@ | |||
| extern crate alloc; | |||
|
|
|||
| use core::assert_matches::assert_matches; | |||
| use std::sync::Arc; | |||
|
|
|||
There was a problem hiding this comment.
It looks like this uses an older version of formatting. Since #4648 it rustfmt should automatically group use statements.
There was a problem hiding this comment.
rustfmt is actively adding a space there. I think it's adding a space dividing external imports from workspace imports.
ernoc
force-pushed
the
proto-crate-2
branch
3 times, most recently
from
c7a16a4
to
473438b
Compare
ernoc
added
the
kokoro:run
kokoro-team
removed
the
kokoro:run
|
I think we could drop the |
k-naliuka
pushed a commit
to k-naliuka/oak
that referenced
this pull request
Feb 5, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Attempt 2.
Use the same approach as we use in internal repo: build generated proto Rust code in its own package (crate).
#4565