oak_runtime: Use prost instead of protobuf-rust #683
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
blaxill
force-pushed
the
oak_runtime_prost
branch
from
f94e41c
to
c8cee4d
Compare
daviddrysdale
approved these changes
Mar 7, 2020
| @@ -26,7 +26,7 @@ fn test_app_config() { | |||
| ); | |||
| let got = format!("{:?}", cfg); | |||
There was a problem hiding this comment.
Does prost have a way of generating text format protobufs? (ie. could we replace this with let got = cfg.to_text() and leave all the asserts as-is?)
There was a problem hiding this comment.
Yeah relying on debug strings does not seem ideal. In fact, why even test via a textual representation at all? It seems the assert could compare against an actual expected struct?
There was a problem hiding this comment.
Changed tests to structs.
tiziano88
approved these changes
Mar 7, 2020
| @@ -26,7 +26,7 @@ fn test_app_config() { | |||
| ); | |||
| let got = format!("{:?}", cfg); | |||
There was a problem hiding this comment.
Yeah relying on debug strings does not seem ideal. In fact, why even test via a textual representation at all? It seems the assert could compare against an actual expected struct?
blaxill
force-pushed
the
oak_runtime_prost
branch
from
f8a7495
to
fdcf6f7
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Switch oak_runtime to prost in preparation for
no_stdsupport.Checklist
cover any TODOs and/or unfinished work.
construction.