Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix and reformat earthquake distance tests #319

Merged

Conversation

tarnold17
Copy link
Contributor

@tarnold17 tarnold17 commented Apr 25, 2024

Fixes/Addresses/Summary/Motivation:

Reformat pareto/tests/test_earthquake_distance.py into multiple small tests instead of one large test, and mark with @pytest.mark.xfail the test which is failing in the GitHub environment.

Update codecov-action to v4 to hopefully resolve the persistent failures we're seeing using v2

Legal Acknowledgement

By contributing to this software project, I agree to the following terms and conditions for my
contribution:

  1. I agree my contributions are submitted under the license terms described in the LICENSE.md file
    at the top level of this directory.
  2. I represent I am authorized to make the contributions and grant the license. If my employer has
    rights to intellectual property that includes these contributions, I represent that I have
    received permission to make contributions and grant the required license on behalf of that
    employer.

JavalVyas2000
JavalVyas2000 previously approved these changes Apr 25, 2024
pareto/tests/test_earthquake_distance.py Show resolved Hide resolved
ElmiraShamlou
ElmiraShamlou previously approved these changes Apr 25, 2024
Copy link
Contributor

@ElmiraShamlou ElmiraShamlou left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link

codecov bot commented Apr 25, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 89.33%. Comparing base (edff9c6) to head (9319fda).

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #319      +/-   ##
==========================================
+ Coverage   89.30%   89.33%   +0.03%     
==========================================
  Files          33       33              
  Lines        5972     5989      +17     
==========================================
+ Hits         5333     5350      +17     
  Misses        639      639              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@tarnold17 tarnold17 merged commit b8227bc into project-pareto:main Apr 25, 2024
9 checks passed
@lbianchi-lbl lbianchi-lbl added the Priority:Normal Normal Priority Issue or PR label Apr 25, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Priority:Normal Normal Priority Issue or PR
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants