Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Check for invalid listener URLs #157

Merged
merged 1 commit into from
Mar 11, 2020
Merged

Check for invalid listener URLs #157

merged 1 commit into from
Mar 11, 2020

Conversation

ghjm
Copy link
Contributor

@ghjm ghjm commented Mar 9, 2020

This PR verifies that the given URL for a Receptor peer does not include extraneous information such as a path, and also checks earlier that it matches one of the known schemes. See ansible/receptor#153.

Copy link
Member

@matburt matburt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Would be good to have some tests for this, otherwise looks good

@Ichimonji10
Copy link
Contributor

Does this mean that --listen=receptor://127.0.0.1:8888 is now invalid?

@ghjm
Copy link
Contributor Author

ghjm commented Mar 10, 2020

Oops, no, I didn't mean to remove receptor://. I'll fix it.

@ghjm
Copy link
Contributor Author

ghjm commented Mar 10, 2020

Actually, receptor:// still works with this code as-is. The string replace is done before we check the set of allowed schemes, so receptor:// has already been translated to rnp:// and passes the test.

@matburt matburt added the gate Gate PR in Zuul CI label Mar 11, 2020
@ansible-zuul ansible-zuul bot merged commit 3dc822b into project-receptor:devel Mar 11, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
gate Gate PR in Zuul CI
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants