BZ #1849656 - Fix you cannot use loops on 'import_tasks' statements #20
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Turns out import_tasks imports the tasks before the actual run is started so it cannot import tasks dynamically based on something generated during the play. include_tasks is the right variant for this. The catch with include_tasks is that environment cannot be set on this task, for this reason the contents of register_with_sources had to be wrapped in a block to apply the environment to all tasks in it.
ares
approved these changes
Jun 22, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Turns out
import_tasksimports the tasks before the actual run isstarted so it cannot import tasks dynamically based on something
generated during the play.
include_tasksis the right variant forthis.
The catch with
include_tasksis that environment cannot be set on thistask, for this reason the contents of
register_with_sourceshad to bewrapped in a block to apply the environment to all tasks in it.