Re-order passthrough node removal #127
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This new ordering removes all passthrough node to passthrough node and passthrough node to ensemble connections before attempting to remove any ensemble to passthrough node connections. On my desktop PC at work this reduces the build time from >240s to <210s for a 256-D cconv network.
mundya
force-pushed
the
alternative-ptn-removal-order
branch
from
0f3f055
to
e01a726
Compare
|
Looks good to me... the comment is quite helpful. |
|
Thank you! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This new ordering removes all passthrough node to passthrough node and passthrough node to ensemble connections before attempting to remove any ensemble to passthrough node connections.
On my desktop PC at work this reduces the build time from >240s to <210s for a 256-D cconv network.