Remove __slots__ from user-facing modules. #164
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The major motivation for this change is that in Python 2 you cannot pickle objects with __slots__ in the general case. This is problematic if you wish to dump place/route artefacts, e.g. for the purposes of plotting. Since I don't believe we're currently memory-bound adding __slots__ probaly isn't very useful and so remvoing this seems like a good idea.
|
LGTM, but is there a reason you'd rather not add the appropriate magic methods? I can see there being a lot of nets and using less memory there still seems like a good idea. |
|
I'd err on the side of "premature optimisation is bad" since if they dominate performance, we're seriously winning (and who wants to test magic methods?). |
|
I agree that premature optimisation is bad. I guess we can always throw things back in. Feel free to merge. |
mossblaser
added a commit
that referenced
this pull request
Jun 16, 2015
Remove __slots__ from user-facing modules.
|
Please bump + release :) |
mundya
added a commit
to project-rig/nengo_spinnaker
that referenced
this pull request
Jun 16, 2015
As per project-rig/rig#164. This should remove pickling related issues.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The major motivation for this change is that in Python 2 you cannot pickle
objects with
__slots__in the general case. This is problematic if you wish todump place/route artefacts, e.g. for the purposes of plotting.
Since I don't believe we're currently memory-bound adding
__slots__probablyisn't very useful and so removing this seems like a good idea.