Make a_star return Routes, not Links. #226
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Previously, use of A* would result in routing trees with some routes described with Links objects, not Routes. For most of human history this didn't cause anything to blow-up but with newer more sophisticated routing table generation everything blows up. Whoops.
|
Whoops indeed. LGTM, thanks. |
mossblaser
added a commit
that referenced
this pull request
Mar 2, 2016
Make a_star return Routes, not Links.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously, use of A* would result in routing trees with some routes described
with Links objects, not Routes. For most of human history this didn't cause
anything to blow-up but with newer more sophisticated routing table generation
everything blows up. Whoops.