Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Stale packages remains when repository is added to same users composer config #59

Closed
ramunasd opened this issue Mar 16, 2016 · 3 comments
Labels

Comments

@ramunasd
Copy link
Collaborator

When instance of satisfy is added to composer config, satis gets packages(branches) from previously generated definitions. Even if branch is removed from vcs repository, satis keeps them and shows as available version.

This issue creates stale packages in composer repository and leads to problems when someone tries to install missing branch.

@ludofleury
Copy link
Collaborator

Sorry, i didnt get you at all
On Wed, 16 Mar 2016 at 14:55, Ramūnas Dronga notifications@github.com
wrote:

When instance of satisfy is added to composer config, satis gets
packages(branches) from previously generated definitions. Even if branch is
removed from vcs repository, satis keeps them and shows as available
version.

This issue creates stale packages in composer repository and leads to
problems when someone tries to install missing branch.


You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub
#59

@ramunasd ramunasd changed the title Stale packages when repository is added to composer config Stale packages remains when repository is added to same users composer config Mar 22, 2016
@ramunasd
Copy link
Collaborator Author

@ludofleury don't worry, i also didn't got from first try :)

Imagine situation when certain user has satis repository and runs satis build periodically. Let's say web url of repository is myrepo.example.com. What happens if this user in it's ~/.composer/config.json has something like this:

{
    "config": {
    },
    "repositories": {
        "example": {
            "type": "composer",
            "url": "http://myrepo.example.com"
        }
    }
}

In this case every time user does satis build, satis takes all repositories (excluding packagist.org), fetches all packages from there and adds to list of available ones. Even if package was removed from VCS, it exists in last build and remains in next ones.

Well, this bug comes not from satisfy itself, but i'm still noticing here.

@ludofleury
Copy link
Collaborator

oh wow. It's on satis I think. Did you open a report there ?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants