BIP 44 derivation path #42
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
armaniferrante
force-pushed
the
armani/bip44
branch
3 times, most recently
from
f590350
to
fcb5d2a
Compare
armaniferrante
commented
Nov 12, 2020
| @@ -112,10 +112,11 @@ const useStyles = makeStyles((theme) => ({ | |||
| }, | |||
| })); | |||
|
|
|||
| function BalanceListItem({ publicKey }) { | |||
| export function BalanceListItem({ publicKey, expandable }) { | |||
There was a problem hiding this comment.
Re-used this component for the derivable accounts component, but without the ability to expand into details.
src/pages/LoginPage.js
Outdated
| successMessage: 'Wallet created', | ||
| }); | ||
| callAsync( | ||
| storeMnemonicAndSeed(mnemonic, seed, password, DERIVATION_PATH.bip44), |
There was a problem hiding this comment.
All newly created wallets will use BIP 44.
armaniferrante
requested review from
garywang,
nathanielparke,
philippe-ftx and
nishadsingh1
and removed request for
garywang
armaniferrante
commented
Nov 13, 2020
armaniferrante
force-pushed
the
armani/bip44
branch
from
fcb5d2a
to
bfa030e
Compare
armaniferrante
force-pushed
the
armani/bip44
branch
from
bfa030e
to
f518fd7
Compare
armaniferrante
force-pushed
the
armani/bip44
branch
from
f518fd7
to
fc2442b
Compare
armaniferrante
force-pushed
the
armani/bip44
branch
from
7b5c60f
to
60198c7
Compare
armaniferrante
commented
Feb 12, 2021
| @@ -6,7 +6,7 @@ import { EventEmitter } from 'events'; | |||
|
|
|||
| export async function generateMnemonicAndSeed() { | |||
| const bip39 = await import('bip39'); | |||
| const mnemonic = bip39.generateMnemonic(128); | |||
| const mnemonic = bip39.generateMnemonic(256); | |||
There was a problem hiding this comment.
Switching to use 24 word mnemonics so that we derive the same keys for ledger.
|
Why not derive to the address level? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Addresses https://github.com/project-serum/spl-token-wallet/issues/9.
BIP 44 derivation path update.
All newly created wallets will use BIP 44, defaulting to the path
m/44'/501'/0'/0'. Existing wallets are unchanged. And restored (from mnemonic) wallets have the option to choose betweenm/44'/501'/0'/0',m/44'/501'/0', and the old deprecated path.