Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added common token bases #88

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

munanadi
Copy link

@munanadi munanadi commented Sep 22, 2021

Wrt. #56

commonBases?: <PublicKey[]> is a prop that can be passed on to the <Swap>
This will show up on top of the list.

The star icon in the token list lets users select their own custom base token apart from the customBases passed as a prop.
The icon also acts like a toggle that reflects the state change also updating local storage.

add remove token bases


I also fixed unnecessary rerenders of TokenDialog. For example it was rendering even when it was not displayed on screen.
Hence used the showTokenDialog bool to trigger its render only when its shown.

This is before using the fix.
bad

This is after we use useMemo to only render when the list is shown
good

This makes the UI a bit faster preventing rerenders. and the UX a little better I hope.
Let me know what you think! :))

@munanadi
Copy link
Author

I did run yarn lint:fix and nothing changes. works fine. any suggestions?

@secretshardul
Copy link
Contributor

yarn lint is behind failed check. Change formatting so yarn lint shows no errors.

https://app.travis-ci.com/github/project-serum/swap-ui/builds/238231690#L239

@secretshardul
Copy link
Contributor

Merged with cyclos-prod

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants