Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Refactor typings to reduce/remove type casts #131

Merged
merged 5 commits into from Sep 19, 2023
Merged

Refactor typings to reduce/remove type casts #131

merged 5 commits into from Sep 19, 2023

Conversation

vinceau
Copy link
Member

@vinceau vinceau commented Sep 18, 2023

Description

This PR does the following:

  • removes avoidable type castings
  • prefer types over interfaces to better communicate intention and match slippi-launcher code style
  • makes some return typing a bit more explicit

@vinceau vinceau merged commit 433d515 into master Sep 19, 2023
10 checks passed
@vinceau vinceau deleted the refactor/typings branch September 19, 2023 05:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@NikhilNarayana NikhilNarayana NikhilNarayana approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@vinceau @NikhilNarayana