feat: update dolphin settings #212
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
NikhilNarayana
changed the title
cnkeats
force-pushed
the
feat/update-dolphin-settings
branch
2 times, most recently
from
4f18453
to
20acadd
Compare
cnkeats
force-pushed
the
feat/update-dolphin-settings
branch
from
20acadd
to
c858145
Compare
NikhilNarayana
force-pushed
the
feat/update-dolphin-settings
branch
2 times, most recently
from
cc6f073
to
1f49340
Compare
NikhilNarayana
force-pushed
the
feat/update-dolphin-settings
branch
from
b5d5c30
to
28f6c9e
Compare
vinceau
requested changes
Sep 19, 2021
vinceau
requested changes
Sep 20, 2021
| Select | ||
| </Button> | ||
| <Tooltip title={tooltipText ?? ""}> | ||
| <span> |
There was a problem hiding this comment.
Why do we need to wrap the Button in a span?
There was a problem hiding this comment.
I think it could be a div or a span, but the reason is because if the Button is disabled the tooltip won't show
There was a problem hiding this comment.
This is correct. The tooltip will also be disabled if its immediate child is disabled. Adding an empty wrapper element is the suggested solution.
…er replay settings from dolphin settings tab
NikhilNarayana
force-pushed
the
feat/update-dolphin-settings
branch
from
8ec7574
to
284f94a
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pushes settings from Launcher to Dolphin when Dolphin is launched. Launcher settings are preferred and used to overwrite Dolphin settings when reasonable (time to launch dolphin is not noticeably affected).
Users that don't use the Launcher will be able to change their settings as normal. However, if everyone is eventually required to use the Launcher, the ability to change settings via Dolphin should either be removed or synced with the Launcher.