Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make slippi logo do a barrel roll on hover #218

Merged
merged 6 commits into from
Sep 12, 2021

Conversation

rapito
Copy link
Contributor

@rapito rapito commented Aug 13, 2021

It's quiet.. too quiet...

giphy

do.a.barrel.roll.mov

@rapito rapito changed the title Make slippi loggo do a barrel roll on hover Make slippi logo do a barrel roll on hover Aug 13, 2021
@vinceau
Copy link
Member

vinceau commented Aug 14, 2021

I love the idea but I don't love the implementation. Specifically this behaviour:

Screen.Recording.2021-08-14.at.11.50.11.am.mov

@rapito
Copy link
Contributor Author

rapito commented Sep 9, 2021

I love the idea but I don't love the implementation. Specifically this behaviour:

Screen.Recording.2021-08-14.at.11.50.11.am.mov

I refactored it to take a different approach.

@vinceau
Copy link
Member

vinceau commented Sep 9, 2021

I love the idea but I don't love the implementation. Specifically this behaviour:
Screen.Recording.2021-08-14.at.11.50.11.am.mov

I refactored it to take a different approach.

Does the new approach address the behaviour I mentioned before? If so, could you include in the PR a screengrab/video of the new behaviour when the mouse enters and leaves before the animation completes?

@rapito
Copy link
Contributor Author

rapito commented Sep 10, 2021

I love the idea but I don't love the implementation. Specifically this behaviour:
Screen.Recording.2021-08-14.at.11.50.11.am.mov

I refactored it to take a different approach.

Does the new approach address the behaviour I mentioned before? If so, could you include in the PR a screengrab/video of the new behaviour when the mouse enters and leaves before the animation completes?

Yes:

asdasdasd.mov

It only rolls once now though. And that's fine :)

src/renderer/components/BouncingSlippiLogo.tsx Outdated Show resolved Hide resolved
src/renderer/components/BouncingSlippiLogo.tsx Outdated Show resolved Hide resolved
src/renderer/components/BouncingSlippiLogo.tsx Outdated Show resolved Hide resolved
@rapito
Copy link
Contributor Author

rapito commented Sep 12, 2021

There.

Copy link
Member

@vinceau vinceau left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@vinceau vinceau merged commit f0cc1b3 into project-slippi:main Sep 12, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants