-
Notifications
You must be signed in to change notification settings - Fork 121
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Make slippi logo do a barrel roll on hover #218
Conversation
I love the idea but I don't love the implementation. Specifically this behaviour: Screen.Recording.2021-08-14.at.11.50.11.am.mov |
I refactored it to take a different approach. |
Does the new approach address the behaviour I mentioned before? If so, could you include in the PR a screengrab/video of the new behaviour when the mouse enters and leaves before the animation completes? |
Yes: asdasdasd.movIt only rolls once now though. And that's fine :) |
There. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
It's quiet.. too quiet...
do.a.barrel.roll.mov