feat: Support spaces in bom author/vendor and cmd exec inside lxc. #487
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
smoser
force-pushed
the
fix/execute-as-array
branch
from
f1be243
to
8d34073
Compare
smoser
commented
Aug 22, 2023
hallyn
reviewed
Aug 22, 2023
smoser
force-pushed
the
fix/execute-as-array
branch
from
8d34073
to
ff4944c
Compare
This changes the interface for container.Execute to be an array of strings rather than a string, and then changes the internal lxc-wrapper pass arguments provided to it through to the lxc 'start' api call. It ultimately allows us to safely call programs with spaces, quotes or other "odd" characters without first serializing them in go and relying on lxc start api call to unserialize them properly. lxc.start would ultimately end up just split the lxc.execute.cmd on spaces. Signed-off-by: Scott Moser <smoser@brickies.net>
hallyn
approved these changes
Aug 22, 2023
The bom test case previously had Author of 'bom-test', which was not realiastic and was intentional to avoid exposing the bug with spaces. Signed-off-by: Scott Moser <smoser@brickies.net>
…nfig Previously there were 3 individual calls to bind stacker into tools/static-stacker. This just changes that to 1 place, so after calling SetupBuildContainerConfig you can use stacker inside. Signed-off-by: Scott Moser <smoser@brickies.net>
smoser
force-pushed
the
fix/execute-as-array
branch
from
ff4944c
to
d349254
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
refactor: Bind stacker binary into container in SetupBuildContainerConfig
Previously there were 3 individual calls to bind stacker into
tools/static-stacker. This just changes that to 1 place, so
after calling SetupBuildContainerConfig you can use stacker inside.
test: Change bom test to contain spaces
The bom test case previously had Author of 'bom-test',
which was not realiastic and was intentional to avoid
exposing the bug with spaces.
fix: Use arrays for execution rather than scalar string.
This changes the interface for container.Execute to be an
array of strings rather than a string, and then changes
the internal lxc-wrapper pass arguments provided to it
through to the lxc 'start' api call.
It ultimately allows us to safely call programs with spaces,
quotes or other "odd" characters without first serializing
them in go and relying on lxc start api call to unserialize
them properly. lxc.start would ultimately end up just
split the lxc.execute.cmd on spaces.
What type of PR is this?
Which issue does this PR fix:
What does this PR do / Why do we need it:
If an issue # is not available please add repro steps and logs showing the issue:
Testing done on this change:
Automation added to e2e:
Will this break upgrades or downgrades?
Does this PR introduce any user-facing change?:
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.