fix: Move bom to top level subcmd, simplify shouldSkipInternalUserns #489
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
smoser
force-pushed
the
fix/bom-not-internal
branch
from
f496e3e
to
b81c240
Compare
|
The majority of the code change here is just code-motion. |
rchincha
reviewed
Aug 22, 2023
smoser
force-pushed
the
fix/bom-not-internal
branch
2 times, most recently
from
d5f3b77
to
659e8d6
Compare
hallyn
approved these changes
Aug 23, 2023
smoser
force-pushed
the
fix/bom-not-internal
branch
from
659e8d6
to
0ed8726
Compare
The bom commands are useful outside of stacker, and since they're exposed to the user, they should *not* be part of the hidden internal-go interface. So, change: - stacker internal-go bom-discover + stacker bom discover Also, shouldSkipInternalUserns was overly complicated as a result of iterative development. It is simpler now and based only on the subcommand name with a single special case for testsuite-check-overlay. Signed-off-by: Scott Moser <smoser@brickies.net>
smoser
force-pushed
the
fix/bom-not-internal
branch
from
0ed8726
to
540b3a1
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The bom commands are useful outside of stacker, and since they're exposed to the user, they should not be part of the hidden internal-go interface.
So, change:
Also, shouldSkipInternalUserns was overly complicated as a result of iterative development. Its simple now and based only on the subcommand name.
What type of PR is this?
Which issue does this PR fix:
What does this PR do / Why do we need it:
If an issue # is not available please add repro steps and logs showing the issue:
Testing done on this change:
Automation added to e2e:
Will this break upgrades or downgrades?
Does this PR introduce any user-facing change?:
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.