Mount atomfs molecule with overlay filesystem with xino=on. #492
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hallyn
approved these changes
Aug 30, 2023
smoser
force-pushed
the
fix/must-mount-with-xino
branch
from
f5d88c1
to
64c2731
Compare
Without xino=on you can end up with duplicate inodes numbers in the same overlayfs mount. Signed-off-by: Scott Moser <smoser@brickies.net>
smoser
force-pushed
the
fix/must-mount-with-xino
branch
from
64c2731
to
22a2ab4
Compare
Codecov Report
@@ Coverage Diff @@
## main #492 +/- ##
===========================
===========================
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
mikemccracken
approved these changes
Aug 30, 2023
|
@smoser tests are failing! |
ugh. |
|
I hit 'rerun failed jobs' https://github.com/project-stacker/stacker/actions/runs/6028557234?pr=492 |
We should just upload alpine:edge into project-stacker's ghcr repo. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Without xino=on you can end up with duplicate inodes numbers in theo same overlayfs filesystem.
What type of PR is this?
Which issue does this PR fix:
What does this PR do / Why do we need it:
If an issue # is not available please add repro steps and logs showing the issue:
Testing done on this change:
Automation added to e2e:
Will this break upgrades or downgrades?
Does this PR introduce any user-facing change?:
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.