Fix/build deps #527
Merged
Fix/build deps #527
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
raharper
force-pushed
the
fix/build-deps
branch
2 times, most recently
from
e9e8404
to
83fdb09
Compare
Codecov Report
@@ Coverage Diff @@
## main #527 +/- ##
=======================================
Coverage 13.32% 13.32%
=======================================
Files 40 40
Lines 5863 5863
=======================================
Hits 781 781
Misses 4954 4954
Partials 128 128 📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
hallyn
reviewed
Oct 20, 2023
hallyn
approved these changes
Oct 27, 2023
doc/install.md is quite out-of-date and does not align with
what's happening in .github/workflows/build.yml
Changes
- Add build-essential (for make and friends)
- Add skopeo/umoci which are needed during build and test
- Use Ubuntu's golang PPA (instead of snap); Jammy's golang-go is
1.18 and current go.mod requires 1.20
- Add in the go module prep and docker clone
Now, install.md says to just run:
sudo ./install-build-deps.sh
make stacker
Note: the Fedora steps are equally out of date; that'll need another
PR.
Signed-off-by: Ryan Harper <rharper@woxford.com>
Signed-off-by: Ryan Harper <rharper@woxford.com>
raharper
force-pushed
the
fix/build-deps
branch
from
83fdb09
to
94cbccd
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
doc/install.md is quite out-of-date and does not align with what's happening in .github/workflows/build.yml
Changes
Now, install.md says to just run:
Note: the Fedora steps are equally out of date; that'll need another PR.
What type of PR is this?
cleanup and documentation
Which issue does this PR fix:
What does this PR do / Why do we need it:
Add script to prepare an Ubuntu 22.04 instance to build stacker
Updated docs to reference the script since docs were out of date.
If an issue # is not available please add repro steps and logs showing the issue:
Testing done on this change:
build stacker
Automation added to e2e:
Will this break upgrades or downgrades?
No
Does this PR introduce any user-facing change?:
No
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.