fix(gzip)!: change the default block size #529
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
raharper
reviewed
Oct 19, 2023
rchincha
force-pushed
the
gzip
branch
2 times, most recently
from
b6a3fe4
to
bf39d9e
Compare
Codecov Report
@@ Coverage Diff @@
## main #529 +/- ##
=======================================
Coverage 13.34% 13.34%
=======================================
Files 40 40
Lines 5852 5852
=======================================
Hits 781 781
Misses 4943 4943
Partials 128 128
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
raharper
reviewed
Oct 19, 2023
There was a problem hiding this comment.
Suggestion in commit message:
A tar layer with the same content but compressed with different gzip blocksize
will result in different sha256sums in the final OCI Image. Ecosystem tools
have one current size in use and stacker's current size differ.
Interactions between a stacker-built OCI image and ecosystem tools
which recompress lower layers results in bloated registries which will have
identical tar content but different compressed sha256 blobs.
Unfortunately, the OCI image spec doesn't standardize/encode this in the
specification document. Hence, we change to the current common block size used
in the ecosystem here in the stacker implementation.
BREAKING CHANGE: the default gzip block size is changed to 256<<12, was previously 256<<10. A tar layer with the same content but compressed with different gzip blocksize will result in different sha256sums in the final OCI Image. Ecosystem tools have one current size in use and stacker's current size differ. Interactions between a stacker-built OCI image and ecosystem tools which recompress lower layers results in bloated registries which will have identical tar content but different compressed sha256 blobs. Unfortunately, the OCI image spec doesn't standardize/encode this in the specification document. Hence, we change to the current common block size used in the ecosystem here in the stacker implementation. We now link against our own fork: github.com/project-stacker/umoci which may change depending on the PR getting merged to upstream. Signed-off-by: Ramkumar Chinchani <rchincha@cisco.com>
Updated. |
raharper
approved these changes
Oct 19, 2023
rchincha
added a commit
to rchincha/stacker
that referenced
this pull request
Nov 17, 2023
BREAKING CHANGE: the default gzip block size is changed to 256<<12, was previously 256<<10. A tar layer with the same content but compressed with different gzip blocksize will result in different sha256sums in the final OCI Image. Ecosystem tools have one current size in use and stacker's current size differ. Interactions between a stacker-built OCI image and ecosystem tools which recompress lower layers results in bloated registries which will have identical tar content but different compressed sha256 blobs. Unfortunately, the OCI image spec doesn't standardize/encode this in the specification document. Hence, we change to the current common block size used in the ecosystem here in the stacker implementation. We now link against our own fork: github.com/project-stacker/umoci which may change depending on the PR getting merged to upstream. Signed-off-by: Ramkumar Chinchani <rchincha@cisco.com> (cherry picked from commit 0cf2d70) Signed-off-by: Ramkumar Chinchani <rchincha@cisco.com>
rchincha
added a commit
to rchincha/stacker
that referenced
this pull request
Nov 17, 2023
BREAKING CHANGE: the default gzip block size is changed to 256<<12, was previously 256<<10. A tar layer with the same content but compressed with different gzip blocksize will result in different sha256sums in the final OCI Image. Ecosystem tools have one current size in use and stacker's current size differ. Interactions between a stacker-built OCI image and ecosystem tools which recompress lower layers results in bloated registries which will have identical tar content but different compressed sha256 blobs. Unfortunately, the OCI image spec doesn't standardize/encode this in the specification document. Hence, we change to the current common block size used in the ecosystem here in the stacker implementation. We now link against our own fork: github.com/project-stacker/umoci which may change depending on the PR getting merged to upstream. Signed-off-by: Ramkumar Chinchani <rchincha@cisco.com> (cherry picked from commit 0cf2d70) Signed-off-by: Ramkumar Chinchani <rchincha@cisco.com>
rchincha
added a commit
that referenced
this pull request
Nov 17, 2023
BREAKING CHANGE: the default gzip block size is changed to 256<<12, was previously 256<<10. A tar layer with the same content but compressed with different gzip blocksize will result in different sha256sums in the final OCI Image. Ecosystem tools have one current size in use and stacker's current size differ. Interactions between a stacker-built OCI image and ecosystem tools which recompress lower layers results in bloated registries which will have identical tar content but different compressed sha256 blobs. Unfortunately, the OCI image spec doesn't standardize/encode this in the specification document. Hence, we change to the current common block size used in the ecosystem here in the stacker implementation. We now link against our own fork: github.com/project-stacker/umoci which may change depending on the PR getting merged to upstream. (cherry picked from commit 0cf2d70) Signed-off-by: Ramkumar Chinchani <rchincha@cisco.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
BREAKING CHANGE: the default gzip block size is changed to 256<<12, was previously 256<<10.
The layers created by ecosystem tools and stacker are different for the same tar content. Unfortunately, the OCI image spec doesn't standardize/encode this in the document. Hence, we standardize in the implementation.
We now link against our own fork: github.com/project-stacker/umoci which may change depending on the PR getting merged to upstream.
What type of PR is this?
Which issue does this PR fix:
What does this PR do / Why do we need it:
If an issue # is not available please add repro steps and logs showing the issue:
Testing done on this change:
Automation added to e2e:
Will this break upgrades or downgrades?
Does this PR introduce any user-facing change?:
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.