fix: use overlay whiteouts when extracting tar layers #577
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rchincha
force-pushed
the
overlay-fix
branch
from
cba80a2
to
f2a36bb
Compare
raharper
reviewed
Dec 12, 2023
rchincha
force-pushed
the
overlay-fix
branch
3 times, most recently
from
04192a3
to
681f7f7
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #577 +/- ##
=======================================
Coverage 57.14% 57.14%
=======================================
Files 64 64
Lines 7516 7516
=======================================
Hits 4295 4295
Misses 2479 2479
Partials 742 742 ☔ View full report in Codecov by Sentry. |
rchincha
force-pushed
the
overlay-fix
branch
from
681f7f7
to
1d9b158
Compare
If a tar layer has a deleted file, a whiteout entry is created. However, when extracting tar and overlay whiteouts are incompatible. Signed-off-by: Ramkumar Chinchani <rchincha@cisco.com>
rchincha
force-pushed
the
overlay-fix
branch
from
1d9b158
to
6c26f9c
Compare
raharper
approved these changes
Dec 13, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If a tar layer has a deleted file, a whiteout entry is created. However, when extracting tar and overlay whiteouts are incompatible.
What type of PR is this?
Which issue does this PR fix:
What does this PR do / Why do we need it:
If an issue # is not available please add repro steps and logs showing the issue:
Testing done on this change:
Automation added to e2e:
Will this break upgrades or downgrades?
Does this PR introduce any user-facing change?:
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.