fix: catch failures in makefile when building skopeo #579
Conversation
Skopeo's build target is an inline shell script. It needs to run with 'set -e' or it will just keep going after it fails. Signed-off-by: Scott Moser <smoser@brickies.net>
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #579 +/- ##
===========================================
+ Coverage 13.02% 57.14% +44.11%
===========================================
Files 40 64 +24
Lines 6057 7516 +1459
===========================================
+ Hits 789 4295 +3506
+ Misses 5136 2479 -2657
- Partials 132 742 +610 ☔ View full report in Codecov by Sentry. |
|
would this be better using (thus avoiding the |
|
I think .ONESHELL and .SHELLFLAGS are wierd (they're like decorators on a rule) but i'm fine to switch to that if other people want that. it seems like |
|
I thought I had commented, if people think ONESHELL and SHELLFLAGS make this better, i'm fine to do that. I guess either ACK the fix here or request changes and I'll comply. |
Skopeo's build target is an inline shell script.
It needs to run with 'set -e' or it will just keep going after it fails.
What type of PR is this?
Which issue does this PR fix:
What does this PR do / Why do we need it:
If an issue # is not available please add repro steps and logs showing the issue:
Testing done on this change:
Automation added to e2e:
Will this break upgrades or downgrades?
Does this PR introduce any user-facing change?:
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.