Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

MVP refactoring for funfacts #23

Merged
merged 5 commits into from
Oct 15, 2017
Merged

MVP refactoring for funfacts #23

merged 5 commits into from
Oct 15, 2017

Conversation

Niranjan-B
Copy link
Member

  1. Refactored FunFacts activity into MVP style.
  2. Changes in FunFactFragment - (i) initialised ButterKnife to get the FAB click-listener working, (ii) concatenated ".png" to the saved screenshot file name to avoid "Format not supported" while sharing on WhatsApp and other apps.

@Niranjan-B
Copy link
Member Author

Niranjan-B commented Jul 2, 2017

Hi @Swati4star , the build is failing with the message -> "You have not accepted the license agreements of the following SDK components:
[Android SDK Build-Tools 25.0.1, Android SDK Platform 25].
Before building your project, you need to accept the license agreements and complete the installation of the missing components using the Android Studio SDK Manager."
The build fail might be because of the differences in Android build tools, Android SDK used by the project and Travis environment. I can change the .travis.yml file and re-push if you want me to?

@Swati4star
Copy link
Member

Yes please. Modify the .travis.yml file.

updating travis
@Swati4star Swati4star merged commit ea055a3 into project-travel-mate:master Oct 15, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants