fix: App bar label issue fixed #575
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@thedevelopersanjeev review this PR |
codersanjeev
suggested changes
Mar 10, 2019
| @@ -37,6 +37,10 @@ | |||
|
|
|||
| <style name="AppTheme.PopupOverlay" parent="ThemeOverlay.AppCompat.Light" /> | |||
|
|
|||
| <style name="ToolbarText" parent="@style/TextAppearance.Widget.AppCompat.Toolbar.Title"> | |||
| <item name="android:textSize">17sp</item> | |||
There was a problem hiding this comment.
change this textSize to 18sp instead of 17sp.
reference - https://stackoverflow.com/questions/9133290/what-is-the-default-actionbar-title-font-size
|
@thedevelopersanjeev can you please review the PR, I made the suggested changes. |
codersanjeev
approved these changes
Mar 10, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
The action bar label used to minimize when changed to orientation mode that should not happen.
Fixes #570
Type of change
Just put an x in the [] which are valid.
How Has This Been Tested?
Please describe the tests that you ran to verify your changes.
./gradlew assembleDebug assembleRelease./gradlew checkstyleChecklist: