Refactored code for runtime permissions #598
Conversation
|
@thedevelopersanjeev Please review |
| @@ -141,9 +141,6 @@ protected void onCreate(Bundle savedInstanceState) { | |||
|
|
|||
| fragmentManager.beginTransaction().replace(R.id.inc, fragment).commit(); | |||
|
|
|||
| // Get runtime permissions for Android M | |||
There was a problem hiding this comment.
why did you remove these? I didnt get the point for this
There was a problem hiding this comment.
I removed these permissions because they will trigger the permissions to be asked if the user is just going to log-in or sign-up. I wanted the permissions to be only used at activities/app sections where it is only necessary.
@thedevelopersanjeev 's implementation could be better but it's already asking for permissions at first time use for user and it doesn't take into account if the user declines all permissions.
| @@ -111,6 +115,25 @@ protected void onCreate(Bundle savedInstanceState) { | |||
| } | |||
| } | |||
|
|
|||
| //Get permissions for making calls and locations | |||
| private void getPermissions() { | |||
There was a problem hiding this comment.
we would need runtime permissions for other places too (not just hotels?)
|
@jtj9817 Any updates? |
|
Closing this due to inactivity. |
Description
Removed the runtime permissions being asked at the start of the app and instead selectively implemented it on the parts of the app where it would be needed.
Fixes #(issue)
Possible fix to #566
Type of change
Just put an x in the [] which are valid.
How Has This Been Tested?
Please describe the tests that you ran to verify your changes.
./gradlew assembleDebug assembleRelease./gradlew checkstyleChecklist: