Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix issue #64 #72

Merged
merged 1 commit into from
Jun 14, 2018
Merged

fix issue #64 #72

merged 1 commit into from
Jun 14, 2018

Conversation

andrea-liu87
Copy link
Contributor

hide toolbar from LoginActivity
change status bar on LoginActivity to black color
screenshot from 2018-06-12 20-53-00

#64

@Swati4star
Copy link
Member

Hi. The changes look good. 👍

Just squash these commits into a single one.

@Swati4star Swati4star self-requested a review June 12, 2018 18:32
@andrea-liu87
Copy link
Contributor Author

Just did new commit. I hope that was the correct way to squash 2 commit.

Copy link
Member

@Swati4star Swati4star left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No. The commits are not squashed into a single one yet. I can still see 2 commits in this PR.

change status bar color to black on LoginActivity (programatically)
@andrea-liu87
Copy link
Contributor Author

manage to merge it into one commit :) after a lot of google

@Swati4star Swati4star merged commit 0dce4bc into project-travel-mate:master Jun 14, 2018
@Swati4star
Copy link
Member

haha! Merged now 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants