#739-Implemented runtime permissions #825
Conversation
|
|
||
|
|
There was a problem hiding this comment.
Mam can u pls help me?...m getting <! DOCTYPE html> error during login time ....how can I solve this error
| == PackageManager.PERMISSION_GRANTED) { | ||
| getLocation(); | ||
| } else { | ||
| Toast.makeText(this, "Permissions Denied", Toast.LENGTH_SHORT).show(); |
There was a problem hiding this comment.
We have been using snackbar everywhere, and please dont use constant strings. Add them to strings.xml
| } else if (ActivityCompat.checkSelfPermission(this, Manifest.permission.ACCESS_FINE_LOCATION) | ||
| == PackageManager.PERMISSION_GRANTED | ||
| && ActivityCompat.checkSelfPermission(this, Manifest.permission.ACCESS_COARSE_LOCATION) | ||
| == PackageManager.PERMISSION_GRANTED) { |
There was a problem hiding this comment.
Shouldnt we ask for permissions if they are not granted?
There was a problem hiding this comment.
We are asking for permissions where this service is called, without giving the permission user can not proceed. In this service we are just checking if the permission is given(we can not call locationManager.requestLocationUpdates without checking if permissions are given or not).
| @@ -26,7 +26,6 @@ | |||
| android:layout_width="match_parent" | |||
| android:layout_height="70dp" | |||
| android:layout_alignParentStart="true" | |||
| android:layout_alignParentTop="true" | |||
| } | ||
|
|
| Manifest.permission.READ_CONTACTS, | ||
| Manifest.permission.WRITE_CONTACTS, |
There was a problem hiding this comment.
why have you removed these? We need these permissions.
There was a problem hiding this comment.
Can u please tell me where u r accessing contact?, Actually i am not able to login as of now in the App becuase of #824.
Description
Removed contact related permissions. I have added runtime permissions to access location at ListViewRealTimeActivity.java and MapViewRealTimeActivity.java.
Fixes #739
Type of change
Just put an x in the [] which are valid.
How Has This Been Tested?
Please describe the tests that you ran to verify your changes.
./gradlew assembleDebug assembleRelease./gradlew checkstyleChecklist: