Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[API Request] API to get the list of upcoming Indian holidays #131

Closed
prabhakar267 opened this issue Oct 3, 2018 · 7 comments · Fixed by #142
Closed

[API Request] API to get the list of upcoming Indian holidays #131

prabhakar267 opened this issue Oct 3, 2018 · 7 comments · Fixed by #142
Assignees
Labels
enhancement New feature or request good first issue Good for newcomers hacktoberfest help wanted Extra attention is needed

Comments

@prabhakar267
Copy link
Member

Using timeanddate.com's list of Indian holidays, generate a JSON for all the holidays in a given year.

  • Cache the response in order to avoid making repeated calls
  • Use the following structure for response (should be a list of following object):
    {
        "date": 1, 
        "day": "Monday", 
        "month": "January", 
        "name": "New Year's Day", 
        "type": "Restricted"
    },
@prabhakar267 prabhakar267 added enhancement New feature or request help wanted Extra attention is needed good first issue Good for newcomers hacktoberfest labels Oct 3, 2018
@harsha444
Copy link

will do this

@sanghisha145
Copy link

I would like to work on this.

@kishan-1234
Copy link

Done with the logic part. Can you please tell where to host the API or should i just print the o/p list of dictionaries as of now?

@prabhakar267
Copy link
Member Author

@harsha444 Can you give the update?
@sanghisha145 If @harsha444 doesn't respond you can take it up
@kishan-1234 The API has to be integrated in the project itself.

@kishan-1234
Copy link

@prabhakar267 I created the API using flask framework. Following is the first three dicts in o/p

[{"date":"1","day":"Monday","month":"January","name":"New Years Day","type":"Restricted Holiday"},{"date":"14","day":"Sunday","month":"January","name":"Pongal","type":"Restricted Holiday"},{"date":"14","day":"Sunday","month":"January","name":"Makar Sankranti","type":"Restricted Holiday"},]

please tell me if this is fine so tht i can create a PR

@prabhakar267
Copy link
Member Author

@kishan-1234 Output looks good, please wait for @harsha444 to respond, If he doesn't respond then you can create an API

@harsha444
Copy link

@kishan-1234 please go ahead and create a PR, I didn't complete it yet.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request good first issue Good for newcomers hacktoberfest help wanted Extra attention is needed
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants