Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Feat]: add support for systemd socket activation #2182

Open
rgl opened this issue Jan 24, 2024 · 4 comments
Open

[Feat]: add support for systemd socket activation #2182

rgl opened this issue Jan 24, 2024 · 4 comments
Labels
feature New feature or request rm-external Roadmap item submitted by non-maintainers

Comments

@rgl
Copy link

rgl commented Jan 24, 2024

Is your feature request related to a problem? Please describe.

I would like to configure zot to use a privileged port like 80 or 443 without granting it the CAP_NET_BIND_SERVICE capability.

Describe the solution you'd like

Would like to configure Zot to use systemd Socket Activation.

For more information, please see:

Describe alternatives you've considered

No response

Additional context

No response

@rgl rgl added the feature New feature or request label Jan 24, 2024
@rchincha rchincha added the rm-external Roadmap item submitted by non-maintainers label Jan 24, 2024
@rchincha
Copy link
Contributor

@rgl thanks for filing this issue.
Do you want to give a shot at a PR?
https://github.com/project-zot/zot/blob/main/examples/zot.service

@rgl
Copy link
Author

rgl commented Jan 24, 2024

I can!

Just so we are on the same page, this means that I will modify the following code, OK?

https://github.com/project-zot/zot/blob/v2.0.0/pkg/api/controller.go#L145-L168

@rchincha
Copy link
Contributor

rchincha commented Jan 24, 2024

@rgl would also just add another zot.socket-service file with [Socket] directive?

@rgl
Copy link
Author

rgl commented Jan 26, 2024

@rchincha the PR is at #2186.

please be aware that I've updated the go.mod too, which I'm unsure if should be included in the PR. please advice in the PR issue.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature New feature or request rm-external Roadmap item submitted by non-maintainers
Projects
None yet
Development

No branches or pull requests

2 participants