Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(sync): syncing OCI artifacts with distribution package fails #1013

Merged
merged 1 commit into from
Dec 9, 2022

Conversation

peusebiu
Copy link
Collaborator

sync OCI artifacts using REST APIs

Signed-off-by: Petu Eusebiu peusebiu@cisco.com

What type of PR is this?

Which issue does this PR fix:

What does this PR do / Why do we need it:

If an issue # is not available please add repro steps and logs showing the issue:

Testing done on this change:

Automation added to e2e:

Will this break upgrades or downgrades?

Does this PR introduce any user-facing change?:


By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@codecov
Copy link

codecov bot commented Nov 23, 2022

Codecov Report

Merging #1013 (666da92) into main (37e6c6d) will increase coverage by 0.02%.
The diff coverage is 91.21%.

@@            Coverage Diff             @@
##             main    #1013      +/-   ##
==========================================
+ Coverage   88.86%   88.89%   +0.02%     
==========================================
  Files          74       74              
  Lines       14850    14967     +117     
==========================================
+ Hits        13197    13305     +108     
- Misses       1290     1297       +7     
- Partials      363      365       +2     
Impacted Files Coverage Δ
pkg/extensions/sync/utils.go 92.62% <86.84%> (-0.60%) ⬇️
pkg/extensions/sync/signatures.go 83.13% <89.74%> (+2.46%) ⬆️
pkg/extensions/sync/on_demand.go 93.56% <100.00%> (+0.12%) ⬆️
pkg/extensions/sync/sync.go 85.71% <100.00%> (+1.12%) ⬆️
pkg/api/routes.go 94.52% <0.00%> (-0.43%) ⬇️

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@peusebiu peusebiu force-pushed the sync_oras_artifacts branch 4 times, most recently from 9856451 to 19fa517 Compare November 28, 2022 14:44
@peusebiu peusebiu force-pushed the sync_oras_artifacts branch 9 times, most recently from 73ed26f to fe74659 Compare December 6, 2022 18:27
@peusebiu peusebiu marked this pull request as ready for review December 6, 2022 18:28
andaaron
andaaron previously approved these changes Dec 8, 2022
sync OCI artifacts using REST APIs

Signed-off-by: Petu Eusebiu <peusebiu@cisco.com>
Copy link
Contributor

@rchincha rchincha left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@rchincha rchincha merged commit 024b13e into project-zot:main Dec 9, 2022
@andaaron andaaron added this to the v2.0.0 milestone Feb 27, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants