cleanup: replaced resty client with http client in sync and moved to … #1016
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
aokirisaki
requested review from
peusebiu,
rchincha and
andaaron
as code owners
peusebiu
reviewed
Nov 24, 2022
peusebiu
reviewed
Nov 24, 2022
aokirisaki
force-pushed
the
remove-resty-sync
branch
2 times, most recently
from
bfd3cfb
to
5eec6a0
Compare
aokirisaki
force-pushed
the
remove-resty-sync
branch
5 times, most recently
from
0b2a21a
to
f261887
Compare
Codecov Report
@@ Coverage Diff @@
## main #1016 +/- ##
==========================================
+ Coverage 88.95% 89.04% +0.09%
==========================================
Files 74 74
Lines 15038 15025 -13
==========================================
+ Hits 13377 13379 +2
+ Misses 1296 1282 -14
+ Partials 365 364 -1
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
aokirisaki
force-pushed
the
remove-resty-sync
branch
5 times, most recently
from
f45d77e
to
50eb5c6
Compare
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
| return false | ||
| } | ||
|
|
||
| fileInfo, err := os.Stat(d) |
Check failure
Code scanning / CodeQL
Uncontrolled data used in path expression
aokirisaki
force-pushed
the
remove-resty-sync
branch
2 times, most recently
from
9c26788
to
8d039b5
Compare
andaaron
reviewed
Dec 20, 2022
aokirisaki
force-pushed
the
remove-resty-sync
branch
from
8d039b5
to
34e0d9d
Compare
Signed-off-by: Ana-Roberta Lisca <ana.kagome@yahoo.com>
aokirisaki
force-pushed
the
remove-resty-sync
branch
from
34e0d9d
to
b912d73
Compare
peusebiu
reviewed
Dec 22, 2022
| } | ||
| } | ||
|
|
||
| artifactManifestBuf, err := json.Marshal(ociArtifact) |
There was a problem hiding this comment.
I think this is my mistake, we already have ociArtifactBuf, no need to marshal again :D.
|
otherwise LGTM |
peusebiu
approved these changes
Dec 22, 2022
rchincha
reviewed
Dec 22, 2022
| @@ -18,10 +19,10 @@ import ( | |||
| "github.com/containers/image/v5/types" | |||
| "github.com/opencontainers/go-digest" | |||
| ispec "github.com/opencontainers/image-spec/specs-go/v1" | |||
| "gopkg.in/resty.v1" | |||
|
go-resty/resty#611 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…common
Signed-off-by: Ana-Roberta Lisca ana.kagome@yahoo.com
What type of PR is this?
Which issue does this PR fix:
#969
What does this PR do / Why do we need it:
If an issue # is not available please add repro steps and logs showing the issue:
Testing done on this change:
Automation added to e2e:
Will this break upgrades or downgrades?
Does this PR introduce any user-facing change?:
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.