Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(scrub): add scrub logic for ImageIndex media type #1031

Merged
merged 1 commit into from
Dec 11, 2022

Conversation

Andreea-Lupu
Copy link
Contributor

Signed-off-by: Andreea-Lupu andreealupu1470@yahoo.com

What type of PR is this?

Which issue does this PR fix:

What does this PR do / Why do we need it:

If an issue # is not available please add repro steps and logs showing the issue:

Testing done on this change:

Automation added to e2e:

Will this break upgrades or downgrades?

Does this PR introduce any user-facing change?:


By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@codecov
Copy link

codecov bot commented Nov 28, 2022

Codecov Report

Merging #1031 (88a28c8) into main (37e6c6d) will increase coverage by 0.04%.
The diff coverage is 95.00%.

@@            Coverage Diff             @@
##             main    #1031      +/-   ##
==========================================
+ Coverage   88.86%   88.91%   +0.04%     
==========================================
  Files          74       74              
  Lines       14850    14879      +29     
==========================================
+ Hits        13197    13230      +33     
+ Misses       1290     1287       -3     
+ Partials      363      362       -1     
Impacted Files Coverage Δ
pkg/storage/scrub.go 92.48% <95.00%> (+3.35%) ⬆️

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@Andreea-Lupu Andreea-Lupu force-pushed the scrub-media-type branch 2 times, most recently from 7f4b9b4 to 0bb29ad Compare November 29, 2022 15:40
@rchincha rchincha added this to the v2.0.0 milestone Nov 29, 2022
andaaron
andaaron previously approved these changes Dec 8, 2022
Signed-off-by: Andreea-Lupu <andreealupu1470@yahoo.com>
Copy link
Contributor

@rchincha rchincha left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants