feat(repodb): add pagination for ImageListForDigest and implement FilterTags #1102
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## main #1102 +/- ##
==========================================
+ Coverage 89.21% 89.23% +0.01%
==========================================
Files 88 88
Lines 18105 18265 +160
==========================================
+ Hits 16152 16298 +146
- Misses 1494 1502 +8
- Partials 459 465 +6
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
andaaron
force-pushed
the
filtertags
branch
2 times, most recently
from
fe058ab
to
b1c8b65
Compare
…terTags ImageListForDigest can now return paginated results, directly from DB. It uses FilterTags, a new method to filter tags (obviously) based on the criteria provided in the filter function. Pagination of tags is now slightly different, it shows all results if no limit and offset are provided. Signed-off-by: Alex Stan <alexandrustan96@yahoo.ro> bug(tests): cli tests for digests expecting wrong size Signed-off-by: Andrei Aaron <aaaron@luxoft.com> (cherry picked from commit 369216d) fix(repodb): do not include repo metadata in search results if no matching tags are identified Signed-off-by: Andrei Aaron <aaaron@luxoft.com>
andaaron
requested review from
shimish2,
rchincha and
peusebiu
as code owners
|
This lgtm. |
laurentiuNiculae
previously approved these changes
Jan 17, 2023
…sed correctly The filter function was called only once per manifest digest. The function is supposed to also take into consideration repometa, but only the first repometa-manifestmeta pair was processed. Also increase code coverage. Signed-off-by: Andrei Aaron <aaaron@luxoft.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
ImageListForDigest can now return paginated results, directly from DB. It uses FilterTags, a new method to filter tags (obviously) based on the criteria provided in the filter function.
Pagination of tags is now slightly different, it shows all results if no limit and offset are provided.
Signed-off-by: Alex Stan alexandrustan96@yahoo.ro
bug(tests): cli tests for digests expecting wrong size
Signed-off-by: Andrei Aaron aaaron@luxoft.com
(cherry picked from commit 369216d)
Signed-off-by: Andrei Aaron aaaron@luxoft.com
What type of PR is this?
feature
Which issue does this PR fix:
The call ImageListForDigest was not returning paginated results, actually it was not returning data from RepoDB, it was using the layout.
What does this PR do / Why do we need it:
FilterTags is a new RepoDB API used to return the images from RepoDB matching an arbitrary function sent as parameter to FilterTags.
This will also be used in other calls from subsequent PRs.
Will this break upgrades or downgrades?
No
Does this PR introduce any user-facing change?:
The ImageListForDigest GraphQL API changes to return only the entries for a specific page of images.
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.