Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(repodb): add PageInfo to GlobalSearch and RepoListWithNewestImage results #1121

Merged
merged 1 commit into from
Jan 18, 2023

Conversation

andaaron
Copy link
Contributor

Which issue does this PR fix:
Resolves #928

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

…e results

Signed-off-by: Alex Stan <alexandrustan96@yahoo.ro>

add page info to dynamo-> feat(repodb): add PageInfo to GlobalSearch and RepoListWithNewestImage results

(cherry picked from commit 4fed42b)
Signed-off-by: Andrei Aaron <aaaron@luxoft.com>
@codecov
Copy link

codecov bot commented Jan 18, 2023

Codecov Report

Merging #1121 (dab5cc1) into main (9294ebb) will increase coverage by 0.05%.
The diff coverage is 98.53%.

@@            Coverage Diff             @@
##             main    #1121      +/-   ##
==========================================
+ Coverage   89.23%   89.28%   +0.04%     
==========================================
  Files          89       89              
  Lines       18294    18370      +76     
==========================================
+ Hits        16324    16401      +77     
  Misses       1504     1504              
+ Partials      466      465       -1     
Impacted Files Coverage Δ
pkg/regexp/regexp.go 88.88% <ø> (ø)
pkg/meta/repodb/dynamodb-wrapper/dynamo_wrapper.go 91.03% <90.47%> (+0.02%) ⬆️
pkg/meta/repodb/pagination.go 98.34% <96.77%> (+0.20%) ⬆️
pkg/api/routes.go 94.00% <100.00%> (ø)
pkg/extensions/search/cve/trivy/scanner.go 95.38% <100.00%> (+0.36%) ⬆️
pkg/extensions/search/resolver.go 87.16% <100.00%> (+0.49%) ⬆️
pkg/extensions/search/schema.resolvers.go 97.50% <100.00%> (+<0.01%) ⬆️
pkg/meta/repodb/boltdb-wrapper/boltdb_wrapper.go 89.86% <100.00%> (+0.02%) ⬆️
pkg/storage/local/local.go 82.67% <100.00%> (+0.10%) ⬆️
pkg/storage/s3/s3.go 80.18% <100.00%> (+0.05%) ⬆️
... and 5 more

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@andaaron andaaron marked this pull request as ready for review January 18, 2023 20:30
Copy link
Contributor

@rchincha rchincha left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

GraphQL: return PageInfo objects for paginated requests (global search and repo list with newest image)
3 participants