Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(repodb): Multiarch Image support #1147

Merged
merged 2 commits into from
Feb 27, 2023
Merged

feat(repodb): Multiarch Image support #1147

merged 2 commits into from
Feb 27, 2023

Conversation

laurentiuNiculae
Copy link
Contributor

Signed-off-by: Laurentiu Niculae niculae.laurentiu1@gmail.com

What type of PR is this?

Which issue does this PR fix:

What does this PR do / Why do we need it:

If an issue # is not available please add repro steps and logs showing the issue:

Testing done on this change:

Automation added to e2e:

Will this break upgrades or downgrades?

Does this PR introduce any user-facing change?:

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@laurentiuNiculae laurentiuNiculae force-pushed the repodb-index-support-main-rebase branch 9 times, most recently from 47335fb to b5ac9b7 Compare January 30, 2023 11:46
@codecov
Copy link

codecov bot commented Jan 30, 2023 •
edited

Codecov Report

Merging #1147 (8d9afa6) into main (a561d0b) will increase coverage by 0.19%.
The diff coverage is 90.01%.

❗ Current head 8d9afa6 differs from pull request most recent head f0feacd. Consider uploading reports for the commit f0feacd to get more accurate results

@@            Coverage Diff             @@
##             main    #1147      +/-   ##
==========================================
+ Coverage   89.67%   89.86%   +0.19%     
==========================================
  Files          92       93       +1     
  Lines       18918    20452    +1534     
==========================================
+ Hits        16965    18380    +1415     
- Misses       1481     1562      +81     
- Partials      472      510      +38
Impacted Files Coverage Δ
pkg/test/common.go 83.72% <74.51%> (-2.87%) ⬇️
pkg/api/controller.go 90.88% <75.00%> (-0.14%) ⬇️
pkg/cli/client.go 86.81% <83.33%> (+5.00%) ⬆️
pkg/extensions/search/cve/cve.go 92.20% <88.07%> (+1.44%) ⬆️
pkg/meta/repodb/boltdb-wrapper/boltdb_wrapper.go 89.22% <88.70%> (-0.66%) ⬇️
pkg/meta/repodb/sync_repodb.go 97.80% <89.79%> (+3.68%) ⬆️
pkg/extensions/search/resolver.go 94.64% <92.45%> (+0.21%) ⬆️
pkg/meta/repodb/dynamodb-wrapper/dynamo_wrapper.go 91.71% <92.54%> (+0.66%) ⬆️
pkg/extensions/search/convert/repodb.go 93.15% <94.11%> (+4.26%) ⬆️
pkg/cli/service.go 82.52% <94.75%> (+3.43%) ⬆️
... and 21 more

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@laurentiuNiculae laurentiuNiculae force-pushed the repodb-index-support-main-rebase branch 4 times, most recently from 0a5a50b to cc45a4c Compare February 2, 2023 18:48
@laurentiuNiculae laurentiuNiculae force-pushed the repodb-index-support-main-rebase branch 13 times, most recently from 8faa410 to f0a2591 Compare February 10, 2023 12:15
andaaron
andaaron reviewed Feb 10, 2023
View reviewed changes
Copy link
Contributor

@andaaron andaaron left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have some concerns with regards to the trivy-related logic. We need to decide what we want to show to the users, and update the PR accordingly.

test/blackbox/cloud-only.bats Outdated Show resolved Hide resolved
pkg/test/common.go Outdated Show resolved Hide resolved
pkg/meta/repodb/dynamodb-wrapper/dynamo_wrapper.go Outdated Show resolved Hide resolved
pkg/meta/repodb/boltdb-wrapper/boltdb_wrapper.go Outdated Show resolved Hide resolved
pkg/extensions/search/resolver.go Show resolved Hide resolved
pkg/extensions/search/common/common_test.go Outdated Show resolved Hide resolved
pkg/extensions/search/common/common_test.go Outdated Show resolved Hide resolved
pkg/cli/service.go Show resolved Hide resolved
pkg/cli/image_cmd_test.go Outdated Show resolved Hide resolved
pkg/cli/image_cmd_test.go Outdated Show resolved Hide resolved
@laurentiuNiculae laurentiuNiculae force-pushed the repodb-index-support-main-rebase branch 2 times, most recently from 4d0e587 to 403a0af Compare February 14, 2023 15:00
@laurentiuNiculae laurentiuNiculae force-pushed the repodb-index-support-main-rebase branch 10 times, most recently from 8323d0a to 7b280fa Compare February 23, 2023 14:13
rchincha
rchincha reviewed Feb 24, 2023
View reviewed changes
pkg/cli/cve_cmd_test.go Outdated Show resolved Hide resolved
andaaron
andaaron reviewed Feb 24, 2023
View reviewed changes
pkg/extensions/search/common/oci_layout.go Outdated Show resolved Hide resolved
pkg/extensions/search/cve/cve.go Outdated Show resolved Hide resolved
pkg/extensions/search/cve/cve.go Outdated Show resolved Hide resolved
pkg/extensions/search/cve/cve_test.go Outdated Show resolved Hide resolved
pkg/extensions/search/cve/trivy/scanner.go Show resolved Hide resolved
pkg/extensions/search/cve/trivy/scanner.go Show resolved Hide resolved
@laurentiuNiculae
feat(repodb): index logic + tests
4be1c5b 
Signed-off-by: Laurentiu Niculae <niculae.laurentiu1@gmail.com>
@laurentiuNiculae laurentiuNiculae force-pushed the repodb-index-support-main-rebase branch 4 times, most recently from 531cc5c to 5d56927 Compare February 27, 2023 16:19
@laurentiuNiculae
feat(cli): printing indexes support using the rest api
f0feacd 
Signed-off-by: Laurentiu Niculae <niculae.laurentiu1@gmail.com>
@rchincha rchincha merged commit d62c09e into project-zot:main Feb 27, 2023
This was linked to issues Feb 27, 2023
RepoDB: support multiarch images #890
Closed
[Bug]: cli will exit with error when listing index(image list) image type #1066
Closed
@andaaron andaaron mentioned this pull request Mar 2, 2023
Closed
andaaron added a commit to andaaron/zot that referenced this pull request Mar 6, 2023
@andaaron
feat(ui): update to the latest zui version which supports new multiar…
b3b05c2 
…ch image APIs

Note patch does not mean full support for showing multiarch images in ZUI,
a single architecture is shown, but it fixes the ZUI views which were broken
since project-zot#1147

Signed-off-by: Andrei Aaron <aaaron@luxoft.com>
rchincha pushed a commit that referenced this pull request Mar 6, 2023
@andaaron
feat(ui): update to the latest zui version which supports new multiar…
c9b594d 
…ch image APIs (#1246)

Note patch does not mean full support for showing multiarch images in ZUI,
a single architecture is shown, but it fixes the ZUI views which were broken
since #1147

Signed-off-by: Andrei Aaron <aaaron@luxoft.com>
@laurentiuNiculae laurentiuNiculae deleted the repodb-index-support-main-rebase branch May 2, 2023 10:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rchincha rchincha rchincha left review comments

@andaaron andaaron andaaron approved these changes

@peusebiu peusebiu Awaiting requested review from peusebiu peusebiu is a code owner

@shimish2 shimish2 Awaiting requested review from shimish2 shimish2 is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[Bug]: cli will exit with error when listing index(image list) image type RepoDB: support multiarch images
3 participants
@laurentiuNiculae @andaaron @rchincha