feat(routes): better error message in case of missing annotations #1150
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
peusebiu
force-pushed
the
lint_better_client_Errs
branch
from
7cdff62
to
eb1b58b
Compare
Codecov Report
@@ Coverage Diff @@
## main #1150 +/- ##
=======================================
Coverage 89.60% 89.60%
=======================================
Files 90 90
Lines 18434 18434
=======================================
Hits 16517 16517
Misses 1459 1459
Partials 458 458 📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
putting this info into error detail would be ideal, but skopeo doesn't print them, so overwrite the error message. Signed-off-by: Petu Eusebiu <peusebiu@cisco.com>
peusebiu
force-pushed
the
lint_better_client_Errs
branch
from
eb1b58b
to
b6c6acd
Compare
andaaron
approved these changes
Feb 1, 2023
|
Let's look at the dist spec and make sure we are not doing something way off. |
rchamarthy
approved these changes
Mar 14, 2023
|
FYI, only the codes matter, rest can be bespoke. |
andaaron
added a commit
to andaaron/zot
that referenced
this pull request
Mar 20, 2023
…fter `go mod tidy` This is to avoid situations such as project-zot#1150 where an indirect dependency became direct without a corresponding go.mod change Signed-off-by: Andrei Aaron <aaaron@luxoft.com>
andaaron
added a commit
to andaaron/zot
that referenced
this pull request
Mar 21, 2023
…fter `go mod tidy` This is to avoid situations such as project-zot#1150 where an indirect dependency became direct without a corresponding go.mod change Signed-off-by: Andrei Aaron <aaaron@luxoft.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
putting this info into error detail would be ideal, but skopeo doesn't print them, so overwrite the error message.
Signed-off-by: Petu Eusebiu peusebiu@cisco.com
What type of PR is this?
Which issue does this PR fix:
#1145
What does this PR do / Why do we need it:
If an issue # is not available please add repro steps and logs showing the issue:
Testing done on this change:
Automation added to e2e:
Will this break upgrades or downgrades?
Does this PR introduce any user-facing change?:
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.