Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(repodb): update referrers api to use repodb #1230

Merged
merged 1 commit into from
Mar 10, 2023

Conversation

laurentiuNiculae
Copy link
Contributor

What type of PR is this?

Which issue does this PR fix:

What does this PR do / Why do we need it:

If an issue # is not available please add repro steps and logs showing the issue:

Testing done on this change:

Automation added to e2e:

Will this break upgrades or downgrades?

Does this PR introduce any user-facing change?:


By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@codecov
Copy link

codecov bot commented Feb 28, 2023

Codecov Report

Merging #1230 (15ffa07) into main (f04e66a) will increase coverage by 0.11%.
The diff coverage is 93.82%.

@@            Coverage Diff             @@
##             main    #1230      +/-   ##
==========================================
+ Coverage   90.05%   90.17%   +0.11%     
==========================================
  Files          95       95              
  Lines       20588    21211     +623     
==========================================
+ Hits        18541    19127     +586     
- Misses       1542     1568      +26     
- Partials      505      516      +11     
Impacted Files Coverage Δ
pkg/test/common.go 84.35% <78.12%> (+0.44%) ⬆️
pkg/api/controller.go 90.73% <80.00%> (-0.14%) ⬇️
pkg/meta/repodb/boltdb-wrapper/boltdb_wrapper.go 89.68% <92.24%> (+0.53%) ⬆️
pkg/meta/repodb/dynamodb-wrapper/dynamo_wrapper.go 92.83% <98.64%> (+1.09%) ⬆️
pkg/extensions/search/convert/repodb.go 93.32% <100.00%> (+0.16%) ⬆️
pkg/extensions/search/resolver.go 94.60% <100.00%> (-0.04%) ⬇️
pkg/extensions/search/schema.resolvers.go 100.00% <100.00%> (ø)
pkg/meta/repodb/common/common.go 97.35% <100.00%> (-1.87%) ⬇️
pkg/meta/repodb/load_repodb.go 100.00% <100.00%> (ø)
pkg/meta/repodb/update/update.go 99.14% <100.00%> (+0.05%) ⬆️
... and 1 more

... and 1 file with indirect coverage changes

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@laurentiuNiculae laurentiuNiculae force-pushed the repodb-oci-artifact branch 5 times, most recently from e9b5ec8 to 02ed918 Compare February 28, 2023 18:18
Copy link
Contributor

@andaaron andaaron left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Partial review.
Please fix these issues, especially the notation/oras manifest ones, will continue with the review after.

.github/workflows/ci-cd.yml Show resolved Hide resolved
errors/errors.go Outdated Show resolved Hide resolved
examples/config-dynamodb.json Outdated Show resolved Hide resolved
pkg/api/routes.go Outdated Show resolved Hide resolved
pkg/test/common.go Outdated Show resolved Hide resolved
pkg/test/common.go Show resolved Hide resolved
pkg/test/common.go Outdated Show resolved Hide resolved
pkg/meta/repodb/update/update_test.go Outdated Show resolved Hide resolved
pkg/storage/common.go Show resolved Hide resolved
@laurentiuNiculae laurentiuNiculae force-pushed the repodb-oci-artifact branch 6 times, most recently from 12db70f to df266e2 Compare March 2, 2023 14:00
pkg/meta/repodb/repodb.go Outdated Show resolved Hide resolved
pkg/extensions/search/resolver.go Show resolved Hide resolved
andaaron
andaaron previously approved these changes Mar 2, 2023
Copy link
Contributor

@andaaron andaaron left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Overall looks good.

andaaron
andaaron previously approved these changes Mar 2, 2023
andaaron
andaaron previously approved these changes Mar 6, 2023
@laurentiuNiculae laurentiuNiculae force-pushed the repodb-oci-artifact branch 6 times, most recently from 820b269 to 8ff3da9 Compare March 9, 2023 14:17
@laurentiuNiculae laurentiuNiculae changed the title feat(repodb): update referrers api to use RepoDB feat(repodb): update referrers api to use repodb Mar 9, 2023
@laurentiuNiculae laurentiuNiculae force-pushed the repodb-oci-artifact branch 7 times, most recently from e8333ac to 5431d7d Compare March 10, 2023 13:20
Signed-off-by: Laurentiu Niculae <niculae.laurentiu1@gmail.com>
Copy link
Contributor

@rchincha rchincha left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@rchincha rchincha merged commit 5d1f91a into project-zot:main Mar 10, 2023
@laurentiuNiculae laurentiuNiculae deleted the repodb-oci-artifact branch May 2, 2023 10:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants