Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(sync): skip already synced images in sync ondemand #1234

Merged
merged 1 commit into from
Mar 7, 2023

Conversation

peusebiu
Copy link
Collaborator

@peusebiu peusebiu commented Mar 1, 2023

What type of PR is this?

Which issue does this PR fix:
#1208

What does this PR do / Why do we need it:

If an issue # is not available please add repro steps and logs showing the issue:

Testing done on this change:

Automation added to e2e:

Will this break upgrades or downgrades?

Does this PR introduce any user-facing change?:


By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@peusebiu peusebiu self-assigned this Mar 1, 2023
@codecov
Copy link

codecov bot commented Mar 1, 2023

Codecov Report

Merging #1234 (ea9ffb3) into main (c2bec0d) will increase coverage by 0.05%.
The diff coverage is 87.21%.

@@            Coverage Diff             @@
##             main    #1234      +/-   ##
==========================================
+ Coverage   89.89%   89.95%   +0.05%     
==========================================
  Files          93       93              
  Lines       20477    20426      -51     
==========================================
- Hits        18408    18374      -34     
+ Misses       1560     1547      -13     
+ Partials      509      505       -4     
Impacted Files Coverage Δ
pkg/extensions/sync/utils.go 89.03% <82.82%> (-2.54%) ⬇️
pkg/extensions/sync/on_demand.go 96.41% <100.00%> (+3.18%) ⬆️
pkg/extensions/sync/sync.go 95.20% <100.00%> (+7.43%) ⬆️
pkg/extensions/extension_search.go 95.61% <0.00%> (-4.39%) ⬇️

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@peusebiu peusebiu changed the title feat(sync):skip already synced images in sync ondemand feat(sync): skip already synced images in sync ondemand Mar 2, 2023
@peusebiu peusebiu force-pushed the sync_skip_on_demand_images branch 3 times, most recently from 12ff447 to 3d6d340 Compare March 3, 2023 12:27
liangyuanpeng
liangyuanpeng previously approved these changes Mar 3, 2023
Copy link

@liangyuanpeng liangyuanpeng left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Have tested for the feature and it's working for me. Thanks for your work. :)

andaaron
andaaron previously approved these changes Mar 6, 2023
Copy link
Contributor

@andaaron andaaron left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Signed-off-by: Petu Eusebiu <peusebiu@cisco.com>
@peusebiu peusebiu dismissed stale reviews from andaaron and liangyuanpeng via ea9ffb3 March 7, 2023 15:28
@peusebiu peusebiu requested a review from rchincha March 7, 2023 17:57
Copy link
Contributor

@rchincha rchincha left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@rchincha rchincha merged commit 79783b4 into project-zot:main Mar 7, 2023
@andaaron andaaron added this to the v2.0.0 milestone Mar 9, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants