-
Notifications
You must be signed in to change notification settings - Fork 91
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(sync): skip already synced images in sync ondemand #1234
Conversation
Codecov Report
@@ Coverage Diff @@
## main #1234 +/- ##
==========================================
+ Coverage 89.89% 89.95% +0.05%
==========================================
Files 93 93
Lines 20477 20426 -51
==========================================
- Hits 18408 18374 -34
+ Misses 1560 1547 -13
+ Partials 509 505 -4
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
12ff447
to
3d6d340
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Have tested for the feature and it's working for me. Thanks for your work. :)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Signed-off-by: Petu Eusebiu <peusebiu@cisco.com>
3d6d340
to
ea9ffb3
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm
What type of PR is this?
Which issue does this PR fix:
#1208
What does this PR do / Why do we need it:
If an issue # is not available please add repro steps and logs showing the issue:
Testing done on this change:
Automation added to e2e:
Will this break upgrades or downgrades?
Does this PR introduce any user-facing change?:
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.