fix(go.mod): replace opencontainers/umoci dependency with project-sta… #1240
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Andreea-Lupu
requested review from
rchincha,
andaaron and
peusebiu
as code owners
Andreea-Lupu
force-pushed
the
replace-umoci-dependency
branch
3 times, most recently
from
f8b56c7
to
3460813
Compare
…cker/umoci Signed-off-by: Andreea-Lupu <andreealupu1470@yahoo.com>
Andreea-Lupu
force-pushed
the
replace-umoci-dependency
branch
from
3460813
to
06b21da
Compare
Codecov Report
@@ Coverage Diff @@
## main #1240 +/- ##
==========================================
- Coverage 89.87% 89.86% -0.01%
==========================================
Files 93 93
Lines 20477 20477
==========================================
- Hits 18403 18402 -1
Misses 1565 1565
- Partials 509 510 +1
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…cker/umoci
What type of PR is this?
Which issue does this PR fix:
What does this PR do / Why do we need it:
Currently, github.com/opencontainers/umoci doesn't offer support for OCI Artifacts. This is the reason for what notation signature blobs are not marked as reachable when GC is performed, so these blobs are removed even if the manifests which contain them still exist. This problem was fixed in github.com/project-stacker/umoci/tree/stacker, so this PR updates the go.mod with this replacement(github.com/opencontainers/umoci => github.com/project-stacker/umoci) in order to solve the presented issue.
If an issue # is not available please add repro steps and logs showing the issue:
Testing done on this change:
Automation added to e2e:
Will this break upgrades or downgrades?
Does this PR introduce any user-facing change?:
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.