Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bug(cve): fix trivyDB being downloaded multiple times in a loop #1255

Merged
merged 1 commit into from
Mar 10, 2023

Conversation

andaaron
Copy link
Contributor

The condition to generate trivyDB download tasks was bugged, and new tasks were generated in case the download had already been successful (state done).

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

The condition to generate trivyDB download tasks was bugged,
and new tasks were generated in case the download had already been
successful (state `done`).

Signed-off-by: Andrei Aaron <aaaron@luxoft.com>
@codecov
Copy link

codecov bot commented Mar 10, 2023

Codecov Report

Merging #1255 (eb9a5e3) into main (f04e66a) will decrease coverage by 0.04%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##             main    #1255      +/-   ##
==========================================
- Coverage   90.05%   90.02%   -0.04%     
==========================================
  Files          95       95              
  Lines       20588    20588              
==========================================
- Hits        18541    18534       -7     
- Misses       1542     1547       +5     
- Partials      505      507       +2     
Impacted Files Coverage Δ
pkg/extensions/extension_search.go 100.00% <100.00%> (ø)

... and 2 files with indirect coverage changes

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

Copy link
Contributor

@laurentiuNiculae laurentiuNiculae left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think it looks good 💯

pkg/extensions/extension_search.go Show resolved Hide resolved
Copy link
Contributor

@rchincha rchincha left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@rchincha rchincha merged commit c731acf into project-zot:main Mar 10, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants