feat(search): update search pattern matching rules

[laurentiuNiculae]

What type of PR is this?

Which issue does this PR fix:
#909

What does this PR do / Why do we need it:

If an issue # is not available please add repro steps and logs showing the issue:

Testing done on this change:

Automation added to e2e:

Will this break upgrades or downgrades?

Does this PR introduce any user-facing change?:

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

[codecov]

Codecov Report

Merging #1257 (9216ed1) into main (a2c3480) will increase coverage by 0.00%.
The diff coverage is 100.00%.

❗ Current head 9216ed1 differs from pull request most recent head 5c403e0. Consider uploading reports for the commit 5c403e0 to get more accurate results

@@           Coverage Diff           @@
##             main    #1257   +/-   ##
=======================================
  Coverage   90.38%   90.39%           
=======================================
  Files          96       96           
  Lines       21324    21332    +8     
=======================================
+ Hits        19273    19282    +9     
+ Misses       1537     1536    -1     
  Partials      514      514           

Impacted Files	Coverage Δ
pkg/extensions/search/common/oci_layout.go	91.08% <ø> (-0.07%)	⬇️
pkg/extensions/search/convert/repodb.go	97.59% <ø> (-0.02%)	⬇️
pkg/meta/repodb/boltdb-wrapper/boltdb_wrapper.go	89.29% <100.00%> (ø)
pkg/meta/repodb/common.go	100.00% <100.00%> (ø)
pkg/meta/repodb/common/common.go	98.19% <100.00%> (+0.84%)	⬆️
pkg/meta/repodb/dynamodb-wrapper/dynamo_wrapper.go	92.61% <100.00%> (ø)

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

[rchincha]

So what is the overall logic for ranking? image:tag first, repo names, and any wildcards? We should eventually also allow searching within annotations. This use case is coming up often.

[andaaron]

So what is the overall logic for ranking? image:tag first, repo names, and any wildcards? We should eventually also allow searching within annotations. This use case is coming up often.

• If a tag is specified (:), the search string for the repo needs to be an exact match. That is a tag search, not a repo search. The logic for that was not changed in this PR.
• If a : is not specified, the repo string is compared to the search string according to the new comments in this PR.

We did not decide on any wildcard, or annotation searches to my knowledge.
At the moment the presence of : signals if this is a repo or a tag search.

What would be a good example of a string the user sends as an annotation search? How would the servers know that is an annotation search, not a repo or a tag search?

Actually I am not convinced searches by annotations are a good idea: which annotations?, on the manifest itself?, on an index?, on descriptors inside a manifest or index?, by annotation key? by annotation value?, by an annotation value on a specific key?

Why would I want to search on an annotation anyway? What is the use case?

[andaaron]

Looks good, please rebase.

[andaaron]

It's good to see we removed score from the graphql api, as we had no benefit in exposing it.

[rchincha]

lgtm