Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(search): add referrers field to ImageSummary #1261

Merged

Conversation

laurentiuNiculae
Copy link
Contributor

@laurentiuNiculae laurentiuNiculae commented Mar 13, 2023

Changed repodb to store more information about the referrer needed for the referrers query

What type of PR is this?

Which issue does this PR fix:
#1238

What does this PR do / Why do we need it:

If an issue # is not available please add repro steps and logs showing the issue:

Testing done on this change:

Automation added to e2e:

Will this break upgrades or downgrades?

Does this PR introduce any user-facing change?:


By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@laurentiuNiculae laurentiuNiculae force-pushed the add-referrers-to-image-summary branch 4 times, most recently from ca84a23 to 33a23ab Compare March 14, 2023 10:41
@codecov
Copy link

codecov bot commented Mar 14, 2023

Codecov Report

Merging #1261 (b73c0c8) into main (17a554b) will decrease coverage by 0.03%.
The diff coverage is 100.00%.

❗ Current head b73c0c8 differs from pull request most recent head 1cabdce. Consider uploading reports for the commit 1cabdce to get more accurate results

@@            Coverage Diff             @@
##             main    #1261      +/-   ##
==========================================
- Coverage   90.20%   90.17%   -0.03%     
==========================================
  Files          96       95       -1     
  Lines       21293    21158     -135     
==========================================
- Hits        19207    19080     -127     
+ Misses       1567     1562       -5     
+ Partials      519      516       -3     
Impacted Files Coverage Δ
pkg/extensions/search/convert/repodb.go 93.68% <100.00%> (+0.36%) ⬆️
pkg/extensions/search/resolver.go 94.68% <100.00%> (ø)
pkg/meta/repodb/boltdb-wrapper/boltdb_wrapper.go 89.29% <100.00%> (-0.45%) ⬇️
pkg/meta/repodb/dynamodb-wrapper/dynamo_wrapper.go 92.61% <100.00%> (-0.24%) ⬇️
pkg/meta/repodb/load_repodb.go 100.00% <100.00%> (ø)

... and 9 files with indirect coverage changes

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@laurentiuNiculae laurentiuNiculae force-pushed the add-referrers-to-image-summary branch 7 times, most recently from d335121 to 08ddeef Compare March 16, 2023 10:26
Changed repodb to store more information about the referrer needed for the referrers query

Signed-off-by: Laurentiu Niculae <niculae.laurentiu1@gmail.com>
Copy link
Contributor

@andaaron andaaron left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@laurentiuNiculae laurentiuNiculae marked this pull request as ready for review March 17, 2023 17:39
@andaaron andaaron linked an issue Mar 17, 2023 that may be closed by this pull request
Copy link
Contributor

@rchincha rchincha left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@rchincha rchincha merged commit ed01292 into project-zot:main Mar 20, 2023
@laurentiuNiculae laurentiuNiculae deleted the add-referrers-to-image-summary branch May 2, 2023 10:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

GraphQL: Include the referrer list in ImageSummary
3 participants