Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(trivy): consistent coverage for reset method + longer wait time b… #1272

Merged
merged 1 commit into from
Mar 22, 2023

Conversation

aokirisaki
Copy link
Contributor

…etween retries

What type of PR is this?

Which issue does this PR fix:
#1259

What does this PR do / Why do we need it:

If an issue # is not available please add repro steps and logs showing the issue:

Testing done on this change:

Automation added to e2e:

Will this break upgrades or downgrades?

Does this PR introduce any user-facing change?:


By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@codecov
Copy link

codecov bot commented Mar 20, 2023

Codecov Report

❗ No coverage uploaded for pull request base (main@a2c3480). Click here to learn what that means.
The diff coverage is 100.00%.

❗ Current head 2faa938 differs from pull request most recent head 15ca1fd. Consider uploading reports for the commit 15ca1fd to get more accurate results

@@           Coverage Diff           @@
##             main    #1272   +/-   ##
=======================================
  Coverage        ?   90.36%           
=======================================
  Files           ?       96           
  Lines           ?    21347           
  Branches        ?        0           
=======================================
  Hits            ?    19290           
  Misses          ?     1542           
  Partials        ?      515           
Impacted Files Coverage Δ
pkg/extensions/extension_search.go 100.00% <100.00%> (ø)
pkg/test/common.go 84.56% <100.00%> (ø)

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@aokirisaki aokirisaki force-pushed the trivy-reset branch 3 times, most recently from 6a7c319 to 8ab1c83 Compare March 20, 2023 14:19
pkg/test/common.go Outdated Show resolved Hide resolved
pkg/extensions/search/cve/cve_test.go Outdated Show resolved Hide resolved
@aokirisaki aokirisaki force-pushed the trivy-reset branch 3 times, most recently from 18e5547 to ce28708 Compare March 21, 2023 15:31
@aokirisaki aokirisaki force-pushed the trivy-reset branch 5 times, most recently from ff5b910 to 2faa938 Compare March 22, 2023 13:16
…etween retries

Signed-off-by: Ana-Roberta Lisca <ana.kagome@yahoo.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants