-
Notifications
You must be signed in to change notification settings - Fork 91
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(trivy): consistent coverage for reset method + longer wait time b… #1272
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
aokirisaki
requested review from
shimish2,
rchincha,
andaaron and
peusebiu
as code owners
March 17, 2023 14:32
aokirisaki
force-pushed
the
trivy-reset
branch
2 times, most recently
from
March 20, 2023 08:48
b1c0e1b
to
59d9aea
Compare
Codecov Report
@@ Coverage Diff @@
## main #1272 +/- ##
=======================================
Coverage ? 90.36%
=======================================
Files ? 96
Lines ? 21347
Branches ? 0
=======================================
Hits ? 19290
Misses ? 1542
Partials ? 515
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
aokirisaki
force-pushed
the
trivy-reset
branch
3 times, most recently
from
March 20, 2023 14:19
6a7c319
to
8ab1c83
Compare
andaaron
reviewed
Mar 20, 2023
aokirisaki
force-pushed
the
trivy-reset
branch
3 times, most recently
from
March 21, 2023 15:31
18e5547
to
ce28708
Compare
andaaron
reviewed
Mar 21, 2023
andaaron
reviewed
Mar 21, 2023
andaaron
reviewed
Mar 21, 2023
andaaron
reviewed
Mar 21, 2023
aokirisaki
force-pushed
the
trivy-reset
branch
5 times, most recently
from
March 22, 2023 13:16
ff5b910
to
2faa938
Compare
…etween retries Signed-off-by: Ana-Roberta Lisca <ana.kagome@yahoo.com>
andaaron
approved these changes
Mar 22, 2023
peusebiu
approved these changes
Mar 22, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…etween retries
What type of PR is this?
Which issue does this PR fix:
#1259
What does this PR do / Why do we need it:
If an issue # is not available please add repro steps and logs showing the issue:
Testing done on this change:
Automation added to e2e:
Will this break upgrades or downgrades?
Does this PR introduce any user-facing change?:
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.