-
Notifications
You must be signed in to change notification settings - Fork 88
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: cleanup error msgs #1273
feat: cleanup error msgs #1273
Conversation
Can you also check the DynamoDB implementation of cache for the same cases? |
83695a5
to
0698fe2
Compare
Signed-off-by: Nicol Draghici <idraghic@cisco.com>
0698fe2
to
671601c
Compare
I also checked DynamoDB and changed log level in some cases and added log messages |
Codecov Report
@@ Coverage Diff @@
## main #1273 +/- ##
==========================================
+ Coverage 90.20% 90.23% +0.02%
==========================================
Files 96 96
Lines 21293 21295 +2
==========================================
+ Hits 19207 19215 +8
+ Misses 1567 1562 -5
+ Partials 519 518 -1
... and 2 files with indirect coverage changes 📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm
What type of PR is this?
Which issue does this PR fix:
What does this PR do / Why do we need it:
If an issue # is not available please add repro steps and logs showing the issue:
Testing done on this change:
Automation added to e2e:
Will this break upgrades or downgrades?
Does this PR introduce any user-facing change?:
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.