Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: cleanup error msgs #1273

Merged
merged 1 commit into from
Mar 20, 2023
Merged

Conversation

nicoldr
Copy link
Contributor

@nicoldr nicoldr commented Mar 17, 2023

What type of PR is this?

Which issue does this PR fix:

What does this PR do / Why do we need it:

If an issue # is not available please add repro steps and logs showing the issue:

Testing done on this change:

Automation added to e2e:

Will this break upgrades or downgrades?

Does this PR introduce any user-facing change?:


By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@andaaron
Copy link
Contributor

Can you also check the DynamoDB implementation of cache for the same cases?

Signed-off-by: Nicol Draghici <idraghic@cisco.com>
@nicoldr nicoldr marked this pull request as ready for review March 20, 2023 12:36
@nicoldr nicoldr requested a review from peusebiu as a code owner March 20, 2023 12:36
@nicoldr
Copy link
Contributor Author

nicoldr commented Mar 20, 2023

Can you also check the DynamoDB implementation of cache for the same cases?

I also checked DynamoDB and changed log level in some cases and added log messages

@nicoldr nicoldr requested a review from rchincha March 20, 2023 12:44
@codecov
Copy link

codecov bot commented Mar 20, 2023

Codecov Report

Merging #1273 (0698fe2) into main (17a554b) will increase coverage by 0.02%.
The diff coverage is 77.77%.

❗ Current head 0698fe2 differs from pull request most recent head 671601c. Consider uploading reports for the commit 671601c to get more accurate results

@@            Coverage Diff             @@
##             main    #1273      +/-   ##
==========================================
+ Coverage   90.20%   90.23%   +0.02%     
==========================================
  Files          96       96              
  Lines       21293    21295       +2     
==========================================
+ Hits        19207    19215       +8     
+ Misses       1567     1562       -5     
+ Partials      519      518       -1     
Impacted Files Coverage Δ
pkg/storage/local/local.go 82.81% <73.33%> (-0.21%) ⬇️
pkg/storage/cache/dynamodb.go 96.77% <100.00%> (ø)

... and 2 files with indirect coverage changes

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

Copy link
Contributor

@rchincha rchincha left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@rchincha rchincha merged commit 0842b02 into project-zot:main Mar 20, 2023
@andaaron andaaron added this to the v2.0.0 milestone Mar 21, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants