refactor(repodb): moving common utilities under pkg/meta #1292
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
laurentiuNiculae
force-pushed
the
repodb-refactor
branch
from
bb89965
to
c57e4db
Compare
andaaron
reviewed
Mar 22, 2023
laurentiuNiculae
force-pushed
the
repodb-refactor
branch
from
c57e4db
to
a926910
Compare
Codecov Report
@@ Coverage Diff @@
## main #1292 +/- ##
==========================================
+ Coverage 90.36% 90.40% +0.03%
==========================================
Files 95 97 +2
Lines 21318 21331 +13
==========================================
+ Hits 19265 19284 +19
+ Misses 1538 1531 -7
- Partials 515 516 +1
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
laurentiuNiculae
force-pushed
the
repodb-refactor
branch
2 times, most recently
from
7a08511
to
521aabc
Compare
andaaron
previously approved these changes
Mar 23, 2023
rchincha
reviewed
Mar 24, 2023
|
Get rid of *-wrapper dirs |
|
#1285 |
Can we fix this in a future PR? I'd do this in smaller steps, and merge more often. This comment too: #1284 (comment) |
Signed-off-by: Laurentiu Niculae <niculae.laurentiu1@gmail.com>
- updated wrapper initialization to recieve a log object in constructor Signed-off-by: Laurentiu Niculae <niculae.laurentiu1@gmail.com>
…meta/repodb Signed-off-by: Laurentiu Niculae <niculae.laurentiu1@gmail.com>
laurentiuNiculae
force-pushed
the
repodb-refactor
branch
from
c151c10
to
90d55f0
Compare
andaaron
approved these changes
Mar 28, 2023
|
This is a intermediate step in our refactoring work. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What type of PR is this?
Which issue does this PR fix:
#1284
What does this PR do / Why do we need it:
If an issue # is not available please add repro steps and logs showing the issue:
Testing done on this change:
Automation added to e2e:
Will this break upgrades or downgrades?
Does this PR introduce any user-facing change?:
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.